From: Antonin Houska <ah@cybertec.at>
To: Andres Freund <andres@anarazel.de>
cc: alvherre@kurilemu.de, pgsql-hackers@lists.postgresql.org,
    Robert Treat <rob@xzilla.net>, Fujii Masao <masao.fujii@gmail.com>,
    Mihail Nikalayeu <mihailnikalayeu@gmail.com>
Subject: Re: Adding REPACK [concurrently]
In-reply-to: <kxzbwwcgtbwbic7t4b2rlmh6n56utxxexydz5z3ppxkjz5mjns@nai3wxnumg6n>
References: <202508201207.wiyqibatotwz@alvherre.pgsql>
 <49679.1755699761@localhost>
 <kxzbwwcgtbwbic7t4b2rlmh6n56utxxexydz5z3ppxkjz5mjns@nai3wxnumg6n>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
   message dated "Wed, 20 Aug 2025 12:11:39 -0400."
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Date: Thu, 21 Aug 2025 20:14:14 +0200
Message-ID: <41238.1755800054@localhost>
Archived-At: 
 <https://www.postgresql.org/message-id/41238.1755800054%40localhost>
Precedence: bulk

Andres Freund <andres@anarazel.de> wrote:

> Hi,
>=20
> On 2025-08-20 16:22:41 +0200, Antonin Houska wrote:
> > =C3=81lvaro Herrera <alvherre@kurilemu.de> wrote:
> >
> > > On 2025-Aug-20, Antonin Houska wrote:
> > >
> > > > There's an issue with the symlink, maybe some meson expert can help=
. In
> > > > particular, the CI on Windows ends up with the following error:
> > > >
> > > > ERROR: Tried to install symlink to missing file C:/cirrus/build/tmp=
_install/usr/local/pgsql/bin/vacuumdb
> > >
> > > Hmm, that's not the problem I see in the CI run from the commitfest a=
pp:
> > >
> > > https://cirrus-ci.com/task/5608274336153600
> >
> > I was referring to the other build that you shared off-list (probably
> > independent from cfbot):
> >
> > https://cirrus-ci.com/build/4726227505774592
> >
> > > [19:11:00.642] FAILED: [code=3D2] src/bin/scripts/vacuumdb.exe.p/vacu=
umdb.c.obj
> > > [19:11:00.642] "cl" "-Isrc\bin\scripts\vacuumdb.exe.p" "-Isrc\include=
" "-I..\src\include" "-Ic:\openssl\1.1\include" "-I..\src\include\port\win3=
2" "-I..\src\include\port\win32_msvc" "-Isrc/interfaces/libpq" "-I..\src\in=
terfaces\libpq" "/MDd" "/nologo" "/showIncludes" "/utf-8" "/W2" "/Od" "/Zi"=
 "/Zc:preprocessor" "/DWIN32" "/DWINDOWS" "/D__WINDOWS__" "/D__WIN32__" "/D=
_CRT_SECURE_NO_DEPRECATE" "/D_CRT_NONSTDC_NO_DEPRECATE" "/wd4018" "/wd4244"=
 "/wd4273" "/wd4101" "/wd4102" "/wd4090" "/wd4267" "/Fdsrc\bin\scripts\vacu=
umdb.exe.p\vacuumdb.c.pdb" /Fosrc/bin/scripts/vacuumdb.exe.p/vacuumdb.c.obj=
 "/c" ../src/bin/scripts/vacuumdb.c
> > > [19:11:00.642] ../src/bin/scripts/vacuumdb.c(186): error C2059: synta=
x error: '}'
> > > [19:11:00.642] ../src/bin/scripts/vacuumdb.c(197): warning C4034: siz=
eof returns 0
> > >
> > > The real problem here seems to be the empty long_options_repack array.
> > > I removed it and started a new run to see what happens.  Running now:
> > > https://cirrus-ci.com/build/4961902171783168
> >
> > The symlink issue occurred at "Windows - Server 2019, MinGW64 - Meson",=
 where
> > the code compiled well. The compilation failure mentioned above comes f=
rom
> > "Windows - Server 2019, VS 2019 - Meson & ninja". I think it's still po=
ssible
> > that the symlink issue will occur there once the compilation is fixed.
>=20
> FWIW, I don't think it's particularly wise to rely on symlinks on windows=
 -
> IIRC they will often not be enabled outside of development environments.

ok, installing a copy of the same executable with a different name seems mo=
re
reliable. At least that's how the postmaster->postgres link used to be
handled, if I read Makefile correctly. Thanks.

--=20
Antonin Houska
Web: https://www.cybertec-postgresql.com