Message-ID: <4124423f-b9bb-40e8-ab4d-a08010ab83ab@tantorlabs.com>
Date: Wed, 26 Feb 2025 13:51:13 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Sample rate added to pg_stat_statements
To: Sami Imseih <samimseih@gmail.com>
Cc: Alexander Korotkov <aekorotkov@gmail.com>,
 Michael Paquier <michael@paquier.xyz>,
 Greg Sabino Mullane <htamfids@gmail.com>,
 Andrey Borodin <x4mmm@yandex-team.ru>,
 Alena Rybakina <a.rybakina@postgrespro.ru>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
References: <fe99e0ca-e564-480e-b865-5f0cee30bc60@tantorlabs.com>
 <e738eac5-ad4d-454c-a079-38766e32ce52@tantorlabs.com>
 <CAA5RZ0s+khQ_u84qS_cAHzxVQQHK_UmWXxRBWTTex7zW1250tQ@mail.gmail.com>
 <0c7770bd-9750-4200-a472-bdb262583c2f@tantorlabs.com>
 <CAA5RZ0vxn_UiUkUK5SdngObLZzw40RhafB7SHydxzBw2_xjjiA@mail.gmail.com>
 <cc1beb52-3e4e-4866-8c32-a5967b98c977@tantorlabs.com>
 <18631d46-1741-4edc-b116-8d9631cdf919@tantorlabs.com>
 <4f98ec33-c627-4eb4-84f3-9994a0982277@tantorlabs.com>
 <CAA5RZ0tJjrX6YiQVDZCOA_BDMuhO-po_T8a3PmjxEEH_iL-qMg@mail.gmail.com>
 <623db69f-b40a-4d50-b1bd-bb073fcc4336@tantorlabs.com>
 <3546e2a7-5831-4c0a-996b-358d4ec483a6@tantorlabs.com>
 <6bf3059f-7ebe-4640-8870-1220f83b88ed@tantorlabs.com>
 <7b9df88f-3015-464b-881e-4c6a7b3a5c03@tantorlabs.com>
 <CAA5RZ0vz+Abyck0dn0fHJ5nTfJU7wdLRxfUj481Ga-BGNY0Txg@mail.gmail.com>
 <6f305fd1-44c3-4189-81ef-238777277e5e@tantorlabs.com>
 <CAA5RZ0trJoVqGmELHOc=G2SxHQHKdTb1aAvzf3vHdfVP8UH+Xg@mail.gmail.com>
Content-Language: en-US
From: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>
In-Reply-To: <CAA5RZ0trJoVqGmELHOc=G2SxHQHKdTb1aAvzf3vHdfVP8UH+Xg@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/4124423f-b9bb-40e8-ab4d-a08010ab83ab%40tantorlabs.com>
Precedence: bulk


On 20.02.2025 03:32, Sami Imseih wrote:
>> As you can see, the query has not been normalized. Is it a bug, expected or undefined behavior?
> No, this behavior is expected. The ability to normalize a statement is
> only available
> during post_parse_analyze (pgss_post_parse_analyze), as this is when
> we have access to
> JumbleState.
>
> In your example, pgss_post_parse_analyze is skipped and during the
> subsequent \bind_named,
> ExecutorEnd (pgss_ExecutorEnd) does not have access to JumbleState,
> leading to the query to be stored without normalization.
>
> It will be nice to make JumbleState available to all hooks, IMO.
>
> --
> Sami


Got it. I think it's worth considering, but not within the scope of this 
thread.

--
Best regards,
Ilia Evdokimov,
Tantor Labs LLC.