Received: from localhost (unknown [200.46.208.211]) by mail.postgresql.org (Postfix) with ESMTP id 92073634C38 for ; Wed, 10 Jun 2009 17:59:10 -0300 (ADT) Received: from mail.postgresql.org ([200.46.204.86]) by localhost (mx1.hub.org [200.46.208.211]) (amavisd-maia, port 10024) with ESMTP id 00948-08 for ; Wed, 10 Jun 2009 17:59:04 -0300 (ADT) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from exprod7og125.obsmtp.com (exprod7og125.obsmtp.com [64.18.2.28]) by mail.postgresql.org (Postfix) with SMTP id BA633634B88 for ; Wed, 10 Jun 2009 17:59:08 -0300 (ADT) Received: from source ([209.85.220.205]) by exprod7ob125.postini.com ([64.18.6.12]) with SMTP ID DSNKSjAemuREvSy8XW28DYeh+t3uRHCvjoIV@postini.com; Wed, 10 Jun 2009 13:59:08 PDT Received: by fxm1 with SMTP id 1so1182373fxm.41 for ; Wed, 10 Jun 2009 13:59:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.119.207 with SMTP id a15mr1728409far.11.1244667546099; Wed, 10 Jun 2009 13:59:06 -0700 (PDT) In-Reply-To: <13137.1244667281@sss.pgh.pa.us> References: <200906101950.n5AJoFP01545@momjian.us> <200906102344.53483.peter_e@gmx.net> <13137.1244667281@sss.pgh.pa.us> From: Greg Stark Date: Wed, 10 Jun 2009 21:58:46 +0100 Message-ID: <4136ffa0906101358l2abe1ee2lf34ba040d1516f1@mail.gmail.com> Subject: Re: pgindent run coming To: Tom Lane Cc: Peter Eisentraut , pgsql-hackers@postgresql.org, Bruce Momjian Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Virus-Scanned: Maia Mailguard 1.0.1 X-Archive-Number: 200906/805 X-Sequence-Number: 139860 On Wed, Jun 10, 2009 at 9:54 PM, Tom Lane wrote: > Peter Eisentraut writes: >>>> I think it usually does that already ... > >> Um, attached you will find a bunch of counterexamples. > > At a quick look, I'm not sure that any of these are in code that hasn't > been edited since the 8.3 pgindent run. On a tangent: git warns about or fixes up white-space problems like that when you're applying a patch. I've actually found this to be a bit of a dilemma though. For code i want it to just go ahead and fix up anything it finds. But for regression test expected output files I don't want it to. I don't think you can control it per-directory though. -- Gregory Stark http://mit.edu/~gsstark/resume.pdf