Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFPts-009mWH-EW for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Dec 2023 02:32:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rFPtq-00EOjL-Vh for pgsql-hackers@arkaria.postgresql.org; Tue, 19 Dec 2023 02:32:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFPtq-00EOjC-MC for pgsql-hackers@lists.postgresql.org; Tue, 19 Dec 2023 02:32:02 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rFPtn-00B66v-D7 for pgsql-hackers@postgresql.org; Tue, 19 Dec 2023 02:32:01 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 3BJ2VsCf4139303; Mon, 18 Dec 2023 21:31:54 -0500 From: Tom Lane To: Nathan Bossart cc: Michael Paquier , Kyotaro Horiguchi , noah@leadboat.com, pgsql-hackers@postgresql.org Subject: Re: add non-option reordering to in-tree getopt_long In-reply-to: <20231218215201.GA586573@nathanxps13> References: <20230710200658.GA362078@nathanxps13> <20230711.161609.1881651378858129172.horikyota.ntt@gmail.com> <20230711163232.GA616878@nathanxps13> <20230713034903.GA991765@nathanxps13> <20230713145712.GA1049722@nathanxps13> <20230714043842.GB327716@nathanxps13> <4007895.1702928482@sss.pgh.pa.us> <20231218215201.GA586573@nathanxps13> Comments: In-reply-to Nathan Bossart message dated "Mon, 18 Dec 2023 15:52:01 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <4139301.1702953114.1@sss.pgh.pa.us> Date: Mon, 18 Dec 2023 21:31:54 -0500 Message-ID: <4139302.1702953114@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Nathan Bossart writes: > On Mon, Dec 18, 2023 at 02:41:22PM -0500, Tom Lane wrote: >> We just had a user complaint that seems to trace to exactly this >> bogus reporting in pg_ctl [1]. Although I was originally not >> very pleased with changing our getopt_long to do switch reordering, >> I'm now wondering if we should back-patch these changes as bug >> fixes. It's probably not worth the risk, but ... > I'm not too concerned about the risks of back-patching these commits, but > if this 19-year-old bug was really first reported today, I'd agree that > fixing it in the stable branches is probably not worth it. Agreed, if it actually is 19 years old. I'm wondering a little bit if there could be some moderately-recent glibc behavior change involved. I'm not excited enough about it to go trawl their change log, but we should keep our ears cocked for similar reports. regards, tom lane