From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Michael Paquier <michael@paquier.xyz>,
        Postgres hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: make -C src/test/isolation failure in index-killtuples due to
 btree_gist
In-reply-to: <lmhmhxxwchxqogb3kybp5w2myvtsamtjkz6y2buowktd3sc3hg@pw5ebya2gifc>
References: <aKJsWedftW7UX1WM@paquier.xyz>
 <lmhmhxxwchxqogb3kybp5w2myvtsamtjkz6y2buowktd3sc3hg@pw5ebya2gifc>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Mon, 18 Aug 2025 09:58:28 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <414028.1755531482.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Mon, 18 Aug 2025 11:38:02 -0400
Message-ID: <414029.1755531482@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/414029.1755531482%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2025-08-18 08:57:13 +0900, Michael Paquier wrote:
>> The following command fails, because btree_gist is not installed in
>> the context of the isolation tests:
>> make -C src/test/isolation/
>> ...
>> and it does not strike me as a good idea to begin doing that in the mai=
n
>> isolation test suite, so perhaps the best thing to do here is just move=
 this
>> test to contrib/btree_gist/?

> No, it makes absolutely no sense to test e.g. hash killtuples support in
> btree_gist.

I think the complaint is that nothing has been done to ensure that
these modules have been installed.  You created a new dependency that
developers have to work around, rather than teaching the build system
to handle it.  As a comparison point, all of the tests in
src/test/recovery, src/test/authentication, etc take care to install
required modules when you say "make check" in those directories.
You broke that for src/test/isolation, and you should fix it.
It shouldn't be much harder than setting EXTRA_INSTALL in the
Makefile case; I dunno about meson.

			regards, tom lane