From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Michael Paquier <michael.paquier@gmail.com>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: assorted code cleanup
In-reply-to: <98ba2e15-250b-8bce-fa4c-777e0d76cd4e@2ndquadrant.com>
References: <2beab0ef-69f9-dab3-cacd-8fdf417bca96@2ndquadrant.com>
 <CAB7nPqQHnB_qS41P+Vsi=CrE3L2rjp37F8WX-dJceLzEWO+rvw@mail.gmail.com>
 <f52c16db-14ed-757d-4b48-7ef360b1631d@2ndquadrant.com>
 <11524.1504639947@sss.pgh.pa.us>
 <98ba2e15-250b-8bce-fa4c-777e0d76cd4e@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Thu, 07 Sep 2017 14:00:18 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4151.1504810380.1@sss.pgh.pa.us>
Date: Thu, 07 Sep 2017 14:53:00 -0400
Message-ID: <4152.1504810380@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 9/5/17 15:32, Tom Lane wrote:
>> I do agree with the idea that we should use the * notation in cases where
>> the reader might otherwise think that a plain function was being invoked,
>> ie I don't like
>> some_function_pointer(args);
>> Even if the compiler isn't confused, readers might be.  But in the case of
>> structname->pointerfield(args);
>> it's impossible to read that as a plain function call, so I'm okay with
>> dropping the extra punctuation there.

> Committed that way.  Thanks.

Is it worth memorializing this in the docs somewhere, perhaps
"53.4. Miscellaneous Coding Conventions" ?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers