Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP4o6-0008Vx-HW for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Mar 2022 15:52:59 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nP4o5-0004Da-1u for pgsql-hackers@arkaria.postgresql.org; Tue, 01 Mar 2022 15:52:57 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP4o3-0004DJ-N7 for pgsql-hackers@lists.postgresql.org; Tue, 01 Mar 2022 15:52:56 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nP4nz-0000YH-3S for pgsql-hackers@lists.postgresql.org; Tue, 01 Mar 2022 15:52:55 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id D07A35C00C1; Tue, 1 Mar 2022 10:52:47 -0500 (EST) Received: from mailfrontend2 ([10.202.2.163]) by compute2.internal (MEProxy); Tue, 01 Mar 2022 10:52:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h= cc:cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm1; bh=H8uIXuM2LJtbGY WhQGUxcyZ/dmmNeF26/4CtcOpSizE=; b=K7c+/ABSVCJh2vUnrdBMY6Ff7uiHvi OVLkptyJponOhzisHc/Ia8MvVP2It57D4+nRCn4tbkg3CT5CVRml+K8wjoH+KpHb Rk2Qx/tZ0YHWa5kVER5Mv9ylx9PBcVQs+9KvR+O9DuaEFKIUDD0lHFFcHqJo5/Ch KpNX4TxXoyc+trrQHxWOdXcXNT+G0L3p4zLJurI7goUEVQ25Xo02L2IekS2iY+0c ObNlU/qKwTCDnqWZTeG8BC5NzpSgaO1zCo04hHxa8lOHkWwjkAE7wHhlkN385LM5 CVKXQH52DoGPWKEBApElAEifvIRVc/eojMkY/qw5DmlXvjcO+OkUQR8Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm2; bh=H8uIXuM2LJtbGYWhQGUxcyZ/dmmNeF26/4CtcOpSi zE=; b=g2DM+HrleTFJUuBnLrAj42n91fAXL39VjsB/6eIrRqcC4QZwZNMGHSw+k N0mxn6wed3XlRuQtTSKrVzVe2mFGecRLETWTeN3mni6fzcCL1W+av4/RDELvJ7pe dCN02DKQJO3kkOkxkK7RnCSjfoSEwxrbnGT6G+8C312WX0guxhDHPU7xPRnVQz8x 0O/mdMtWL3ntDNAhiaw0iazSp2oEZzYHDk8NeQ3BsMLZbH/KVm10jawvwSyOLZ/L gQElbR47C/WpjlZtpOuVMjklPGN96VG+cPv7Wu1yMPemdP9xExycN6oa2wFsJhmw 0DRkZgyqwQ+MmgyItO0tan7JnV5xQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvvddruddtvddgjeelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffufggjfhfkgggtgfesthhqmhdttderjeenucfhrhhomheptehnughr vghsucfhrhgvuhhnugcuoegrnhgurhgvshesrghnrghrrgiivghlrdguvgeqnecuggftrf grthhtvghrnhepkeejudetheefgfeuvddthfeiudefledvieefudeiuedvvdfhuddugfeh teefieejnecuffhomhgrihhnpehgihhthhhusgdrtghomhdpphhoshhtghhrvghsqhhlrd horhhgnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep rghnughrvghssegrnhgrrhgriigvlhdruggv X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 1 Mar 2022 10:52:46 -0500 (EST) Date: Tue, 01 Mar 2022 07:52:43 -0800 From: Andres Freund To: pgsql-hackers@lists.postgresql.org, Andrew Dunstan , Tom Lane , Peter Eisentraut CC: pgsql-hackers@postgresql.org Subject: Re: convert libpq uri-regress tests to tap test User-Agent: K-9 Mail for Android In-Reply-To: <5bbac9ff-09a4-61e7-5bf9-a74c75d84bf8@dunslane.net> References: <20220223203031.ezrd73ohvjgfksow@alap3.anarazel.de> <1261838.1645657117@sss.pgh.pa.us> <4f4c04c2-f23c-6668-1b24-224fc6478bfd@enterprisedb.com> <1276236.1645667561@sss.pgh.pa.us> <95fdebab-adaa-4d00-165b-e58b9b63b94d@dunslane.net> <5bbac9ff-09a4-61e7-5bf9-a74c75d84bf8@dunslane.net> Message-ID: <415675D7-0D06-4712-9CD5-397377671273@anarazel.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi,=20 On March 1, 2022 7:44:27 AM PST, Andrew Dunstan wr= ote: > >On 2/24/22 07:19, Andrew Dunstan wrote: >> On 2/23/22 20:52, Tom Lane wrote: >>> Peter Eisentraut writes: >>>> On 23=2E02=2E22 23:58, Tom Lane wrote: >>>>> Peter Eisentraut writes: >>>>>> libpq TAP tests should be in src/interfaces/libpq/t/=2E >>>>> That's failing to account for the fact that a libpq test can't >>>>> really be a pure-perl TAP test; you need some C code to drive the >>>>> library=2E >>>> Such things could be put under src/interfaces/libpq/test, or some oth= er=20 >>>> subdirectory=2E We already have src/interfaces/ecpg/test=2E >>> OK, but then the TAP scripts are under src/interfaces/libpq/test/t, >>> which isn't what you said=2E I have no great objection to moving >>> src/test/modules/libpq_pipeline/ to src/interfaces/libpq/test/, >>> though, as long as the buildfarm will cope=2E >>> >>> =09 >> >> It won't without some adjustment=2E > > > >See > >and > Thanks!=20 --=20 Sent from my Android device with K-9 Mail=2E Please excuse my brevity=2E