From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: Bruce Momjian <bruce@momjian.us>, Julien Rouhaud <rjuju123@gmail.com>,
        Robert Haas <robertmhaas@gmail.com>,
        Michael Paquier <michael@paquier.xyz>,
        torikoshia <torikoshia@oss.nttdata.com>,
        Atsushi Torikoshi <atorik@gmail.com>,
        Tatsuro Yamada <tatsuro.yamada.tf@nttcom.co.jp>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Evgeny Efimkin <efimkin@yandex-team.ru>,
        PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Feature improvement: can we add queryId for
 pg_catalog.pg_stat_activity view?
In-reply-to: <20201016160355.GA31474@alvherre.pgsql>
References: <20201016160355.GA31474@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Fri, 16 Oct 2020 13:03:55 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4157147.1602865409.1@sss.pgh.pa.us>
Date: Fri, 16 Oct 2020 12:23:29 -0400
Message-ID: <4157148.1602865409@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> In this case, I suppose using pg_stat_statement would require to have it
> enabled, and it'd just not collect anything if disabled.

Alternatively, pg_stat_statement might be able to force it on
(applying a non-overridable PGC_INTERNAL-level setting) on load?
Not sure if that'd be desirable or not.

If the behavior of pg_stat_statement is to do nothing when it
sees a query without the ID calculated (which I guess it'd have to)
then there's a potential security issue if the GUC is USERSET level:
a user could hide her queries from pg_stat_statement by turning the
GUC off.  So this line of thought suggests the GUC needs to be at
least SUSET, and maybe higher ... doesn't pg_stat_statement need it
to have the same value cluster-wide?

			regards, tom lane