Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cty6v-00033l-Vk for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Mar 2017 15:05:10 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cty6v-0004fl-Er for pgsql-hackers@arkaria.postgresql.org; Fri, 31 Mar 2017 15:05:09 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cty5L-0001qv-5I for pgsql-hackers@postgresql.org; Fri, 31 Mar 2017 15:03:31 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cty5I-0001NH-Ia for pgsql-hackers@postgresql.org; Fri, 31 Mar 2017 15:03:29 +0000 Received: from Davids-MacBook.local (unknown [208.123.164.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 4545455687; Fri, 31 Mar 2017 15:03:27 +0000 (UTC) Subject: Re: PATCH: Batch/pipelining support for libpq To: Vaishnavi Prabakaran , Craig Ringer References: <3200d6d3-a82a-4778-b021-475b3adbe4dc@manitou-mail.org> Cc: Daniel Verite , Michael Paquier , "Prabakaran, Vaishnavi" , Haribabu Kommi , "Tsunakawa, Takayuki" , Dmitry Igrishin , Andres Freund , PostgreSQL Hackers , Manuel Kniep , "fujita.etsuro@lab.ntt.co.jp" , "Iwata, Aya" From: David Steele Message-ID: <41685247-0a06-1fbb-d731-1b2b6bd8df8e@pgmasters.net> Date: Fri, 31 Mar 2017 11:03:26 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <3200d6d3-a82a-4778-b021-475b3adbe4dc@manitou-mail.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -1.9 (-) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org Hi, On 3/30/17 2:12 PM, Daniel Verite wrote: > Vaishnavi Prabakaran wrote: > >> Hmm, With batch mode, after sending COPY command to server(and server >> started processing the query and goes into COPY state) , client does not >> immediately read the result , but it keeps sending other queries to the >> server. By this time, server already encountered the error >> scenario(Receiving different message during COPY state) and sent error >> messages > > IOW, the test intentionally violates the protocol and then all goes wonky > because of that. > That's why I was wondering upthread what's it's supposed to test. > I mean, regression tests are meant to warn against a desirable behavior > being unknowingly changed by new code into an undesirable behavior. > Here we have the undesirable behavior to start with. > What kind of regression could we fear from that? The CF has been extended until April 7 but time is still growing short. Please respond with a new patch by 2017-04-04 00:00 AoE (UTC-12) or this submission will be marked "Returned with Feedback". Thanks, -- -David david@pgmasters.net -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers