From: Tom Lane <tgl@sss.pgh.pa.us>
To: Heikki Linnakangas <hlinnaka@iki.fi>
cc: Peter Eisentraut <peter@eisentraut.org>,
        pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fix inappropriate uses of atol()
In-reply-to: <0d3b4dfa-afa2-4f1c-9b30-e2acbdeb2e64@iki.fi>
References: <a52738ad-06bc-4d45-b59f-b38a8a89de49@eisentraut.org> <0d3b4dfa-afa2-4f1c-9b30-e2acbdeb2e64@iki.fi>
Comments: In-reply-to Heikki Linnakangas <hlinnaka@iki.fi>
	message dated "Sat, 03 Aug 2024 17:07:46 +0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4169217.1722698413.1@sss.pgh.pa.us>
Date: Sat, 03 Aug 2024 11:20:13 -0400
Message-ID: <4169218.1722698413@sss.pgh.pa.us>
Archived-At: <https://www.postgresql.org/message-id/4169218.1722698413%40sss.pgh.pa.us>
Precedence: bulk

Heikki Linnakangas <hlinnaka@iki.fi> writes:
> On 03/08/2024 14:04, Peter Eisentraut wrote:
>> I noticed (during [0]) to some uses of the function atol() seem 
>> inappropriate.

> +1 except for this one:

>> /* If we have just one character this is not a string */
>> -			if (atol(p->type->size) == 1)
>> +			if (atoi(p->type->size) == 1)
>>  				mmerror(PARSE_ERROR, ET_ERROR, "invalid data type");

How about

-			if (atol(p->type->size) == 1)
+			if (strcmp(p->type->size, "1") == 0)

?  I've not actually tested, but this should catch the cases the
warning is meant to catch while not complaining about any of the
examples you give.  I'm not sure if leading/trailing spaces
would fool it (i.e., "char foo[ 1 ];").  But even if they do,
that doesn't seem disastrous.

			regards, tom lane