Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rkeZI-00EJor-Nf for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2024 06:27:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rkeZC-00FTXE-52 for pgsql-hackers@arkaria.postgresql.org; Thu, 14 Mar 2024 06:27:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rkeZA-00FTX6-Ht for pgsql-hackers@lists.postgresql.org; Thu, 14 Mar 2024 06:27:50 +0000 Received: from fout4-smtp.messagingengine.com ([103.168.172.147]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rkeZ7-004QqL-33 for pgsql-hackers@postgresql.org; Thu, 14 Mar 2024 06:27:48 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailfout.nyi.internal (Postfix) with ESMTP id DFF7A13800CD; Thu, 14 Mar 2024 02:27:42 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 14 Mar 2024 02:27:42 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eisentraut.org; h=cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm3; t=1710397662; x=1710484062; bh=FH1bh1koVAmPkSmbMRDeypPvuJ51AS2Ckmb8S+40xwI=; b= uH2t0TDJQR16YdlLtNZp3BPqj9EBsljBkwgYRWkGK+ICPWRZl+UHgmFkWL7jtTug vYxNhh2Bz06t/7VGwdg8Uw4YAirkhSn3vHu8tHoJsa5YEAnXSDu21VqgxmdPwejC D0v2v7GaEx3VPT/k5qS8CotmD3R4Px/J3ReD00tSuaGOLvPY2bxHVZafS2Hlt5xR pC2FbIbNHGSxCh5HJsJWKbC9dFYDuHJMXD9q9RPpboLVD7Q1z40ydVrL1YO+Wq07 P+bFvnR9bbZaVK9pAfIuFCoTIgD2kPBJA+RV6KB4qUL+AHq9zbIZVh7Ehf3Ck4+9 VG9HYxKPGJPu9MgRDXfkdA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1710397662; x= 1710484062; bh=FH1bh1koVAmPkSmbMRDeypPvuJ51AS2Ckmb8S+40xwI=; b=A oOOhlJ7SiMuKU6QmCIYE0XDMMPXmm8fdUinqEF3OOjVYlnPAum1nEUGuoNaTkw1d Nhbom76AeoRewy52Lr6MXENLBA+kSwV2IZQFf6B5PxMtVLaEYF+0V7PhXRZqesrQ aD/9B89L4D4gwngpOxl0ha6Nmx0uFHKWJM5JU+xgY7KwHhklVC+vSRkg8pEWnalR W8MVbeinBSuBYd23TDs3lMn5GD1wGrXp0IMENGXdbc92YBLFT6t87DikWeuL5F/l lhwcAD3bOoQhd6HWhf2EolrPwgJ+pD9Vy4+EswZ0mzK7RZJsEkYxOZLpy0pB9Nj+ H0Me4j0J8ykYmW8I+5PDg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvledrjeeigdeludcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfhfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpefrvghtvghr ucfgihhsvghnthhrrghuthcuoehpvghtvghrsegvihhsvghnthhrrghuthdrohhrgheqne cuggftrfgrthhtvghrnhepheeivdfhuefhueeggfefheegjedtveeuhfethfeufedvudfg tdeuhefgfeduhfffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh hfrhhomhepphgvthgvrhesvghishgvnhhtrhgruhhtrdhorhhg X-ME-Proxy: Feedback-ID: ie0a040ee:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 14 Mar 2024 02:27:42 -0400 (EDT) Message-ID: <416c81c6-aa1a-489a-9bd1-e5c3aed92384@eisentraut.org> Date: Thu, 14 Mar 2024 07:27:40 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Put genbki.pl output into src/include/catalog/ directly Content-Language: en-US To: Andreas Karlsson , pgsql-hackers References: <21b74bdc-183d-4dd5-9c27-9378d178f459@eisentraut.org> <640bfcf4-bd2b-40ac-b38b-f2d464a57f83@proxel.se> <68783b20-60e9-4adb-a7be-74c70daa626e@proxel.se> From: Peter Eisentraut In-Reply-To: <68783b20-60e9-4adb-a7be-74c70daa626e@proxel.se> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 14.03.24 02:33, Andreas Karlsson wrote: > On 3/13/24 12:41 PM, Andreas Karlsson wrote: >> On 2/8/24 8:58 AM, Peter Eisentraut wrote: >>> I think keeping the two build systems aligned this way will be useful >>> for longer-term maintenance. >> >> Agreed, so started reviewing the patch. Attached is a rebased version >> of the patch to solve a conflict. > > I have reviewed the patch now and would say it looks good. I like how we > remove the symlinks plus make things more similar to the meson build so > I think we should merge this. > > I tried building, running tests, running make clean, running make > install and tried building with meson (plus checking that meson really > checks for the generated files and actually refuse to build). Everything > worked as expected. > > The code changes look clean and mostly consist of moving code. I > personally think this is ready for committer. Committed, thanks.