Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG3Gh-0006rg-TC for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Sep 2020 16:48:23 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1kG3Gg-0001g9-Dd for pgsql-hackers@arkaria.postgresql.org; Wed, 09 Sep 2020 16:48:22 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG3Gg-0001fq-6s for pgsql-hackers@lists.postgresql.org; Wed, 09 Sep 2020 16:48:22 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kG3Gd-0000gL-Py for pgsql-hackers@lists.postgresql.org; Wed, 09 Sep 2020 16:48:21 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 089GmHtk041714; Wed, 9 Sep 2020 12:48:17 -0400 From: Tom Lane To: Fujii Masao cc: pgsql-hackers@lists.postgresql.org, Fujii Masao Subject: Re: Remove line length restriction in passwordFromFile() In-reply-to: <12eff40e-80df-244e-86b8-c60b0e88bc75@oss.nttdata.com> References: <4187382.1598909041@sss.pgh.pa.us> <90aed8c6-a171-4cf7-4e4a-0d4d9593f6c5@oss.nttdata.com> <54742.1598973287@sss.pgh.pa.us> <12eff40e-80df-244e-86b8-c60b0e88bc75@oss.nttdata.com> Comments: In-reply-to Fujii Masao message dated "Thu, 10 Sep 2020 01:34:48 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <41712.1599670097.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Wed, 09 Sep 2020 12:48:17 -0400 Message-ID: <41713.1599670097@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Fujii Masao writes: > The patch was back-patched to v13, but v13 release note still has the fo= llowing item. > Tighten libpq's overlength-line handling and comment detection for = .pgpass files (Fujii Masao) > This should be changed to the following or something? > Teach libpq to handle arbitrary-length lines in .pgpass files (Tom = Lane) Hm. Actually, since that went further back than v13, I don't think it should appear in the v13 notes at all; it will be material for the next quarterly update release notes. We could adjust the release-note entry for your patch to say "Improve comment detection for .pgpass files", or we could decide it's not worth documenting that part and just drop the entry. regards, tom lane