Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bD7ED-000242-3L for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jun 2016 09:35:18 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1bD7EC-0001yO-Gy for pgsql-hackers@arkaria.postgresql.org; Wed, 15 Jun 2016 09:35:16 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bD7Cq-0006YG-1M for pgsql-hackers@postgresql.org; Wed, 15 Jun 2016 09:33:52 +0000 Received: from nm25-vm5.bullet.mail.sg3.yahoo.com ([106.10.151.100]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1bD7Cl-0005VJ-MW for pgsql-hackers@postgresql.org; Wed, 15 Jun 2016 09:33:51 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.co.in; s=s2048; t=1465983222; bh=YIp1gctNIE8rb/Si1Y9g4Jlz8uaqajGRdu16IQRM9rU=; h=Date:From:Reply-To:To:Cc:In-Reply-To:References:Subject:From:Subject; b=b7qfSSFvUU2SNcD/tYWz8utl713TsXcp1Kw7XiFYPKhWejtUEmy6EBpeqTXm8DwLph7ZSveCH3ga+NYTjtKV9X08k1qVxexyiUn8dzw8dsgUth8Fkdg8eYW8D9qkXga2m6S//RmP+Eeu4g33vmcHGFX9SpRAU+FHNQ8sKAZz+iNNEKzgVeDwdvxo/gZZHbsuR+JWyleUGBinW7VUVINFlCYpBqyngAquIKF0Fpsif9RKbxSPcwOh1+nVXDEITT4pGIC3pPMw6uYddDLqjeYTFVGu9aXYMCILsWAlD7osIj5vBGUlf6YA/SF4VVtFmuI78vIyj9/xmhF0tCQlRTVcNw== Received: from [106.10.166.126] by nm25.bullet.mail.sg3.yahoo.com with NNFMP; 15 Jun 2016 09:33:42 -0000 Received: from [106.10.151.254] by tm15.bullet.mail.sg3.yahoo.com with NNFMP; 15 Jun 2016 09:33:42 -0000 Received: from [127.0.0.1] by omp1003.mail.sg3.yahoo.com with NNFMP; 15 Jun 2016 09:33:42 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 66555.70364.bm@omp1003.mail.sg3.yahoo.com X-YMail-OSG: XAGxWS0VM1kaJo.8dWhfPesR74zeIoHQxRJvCgS_UC..RLKAiY7lSZYqemcdYAz 6CzGCAfvH5EnjkigxXVYzY2R0Kjx_iNfK6e.L9XoWbaGdMXbxyk.GqVFUq1UcacFG51Azj9ed4jo X55ixMt8MDPGFe50z4K6B6meQsh6T9gUU7Iw1Egi1vyMWLV_P2yKDE7ucMFfEJcea0Bm_7HbZiXo xcQ.rxsPILPeubt4zf6TULz1rBl32ce8TsICdC5LvYsKmjvTLuAJQaCxF_2k.FkYngJMPqsOpC4L ocnczsj0HsTKY3tJwjqxLU1FG7a0rZ6YFMvm5cC5JUI9pum_ugG7XBTw5Q7N5v2AhO_TGrrfMn6u u8ISKohNbjUgez7kN3GWJZWjxuaa_TxsJVSs_dyhW0W5YF_vP2db_pqfHuovFWC2xofu8LsEBSX6 qZuJhkxIUOcZmUduYeALWrDeBm9wTulVdbxltMEh97kHy84KlBGh0AQgqRXDw5rCBS4cjeaTHGXG 10ky6Bhrko0rOKC483UEaMHmUVrmdChvSGB0- Received: from jws10910.mail.sg3.yahoo.com by sendmailws101.mail.sg3.yahoo.com; Wed, 15 Jun 2016 09:33:41 +0000; 1465983221.593 Date: Wed, 15 Jun 2016 09:33:41 +0000 (UTC) From: amul sul Reply-To: amul sul To: Robert Haas , Tom Lane Cc: PostgreSQL-development Message-ID: <417387085.2692378.1465983221272.JavaMail.yahoo@mail.yahoo.com> In-Reply-To: References: <1873520224.1784572.1465833145330.JavaMail.yahoo.ref@mail.yahoo.com> <1873520224.1784572.1465833145330.JavaMail.yahoo@mail.yahoo.com> <20932.1465834344@sss.pgh.pa.us> Subject: Re: Bug in to_timestamp(). MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="----=_Part_2692377_1985140396.1465983221272" Content-Length: 6756 X-Pg-Spam-Score: -2.7 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org ------=_Part_2692377_1985140396.1465983221272 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On Monday, 13 June 2016 9:57 PM, Robert Haas wrote: >I think a space in the format string should skip a whitespace >character in the input string, but not a non-whitespace character. +1, enough the benefit is we are giving correct output. PFA patch proposing this fix. Regards, Amul Sul. ------=_Part_2692377_1985140396.1465983221272 Content-Type: application/octet-stream Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-RM37358-space-in-the-format-string-should-skip-a-whi.patch Content-ID: RnJvbSBlNzkwMDFhOTEyYzliOGJmYmNkNWVlZjI0ZmNhNjFmNGFjMDhiZWNi IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbXVsIFN1bCA8c3Vs X2FtdWxAeWFob28uY28uaW4+CkRhdGU6IFdlZCwgMTUgSnVuIDIwMTYgMTQ6 NDI6NDMgKzA1MzAKU3ViamVjdDogW1BBVENIXSBSTTM3MzU4OiBzcGFjZSBp biB0aGUgZm9ybWF0IHN0cmluZyBzaG91bGQgc2tpcCBhIHdoaXRlc3BhY2UK IGluIGlucHV0CgotLS0KIHNyYy9iYWNrZW5kL3V0aWxzL2FkdC9mb3JtYXR0 aW5nLmMgICAgIHwgMjAgKysrKysrKysrKysrKysrKy0tLS0KIHNyYy90ZXN0 L3JlZ3Jlc3MvZXhwZWN0ZWQvaG9yb2xvZ3kub3V0IHwgMTIgKysrKysrLS0t LS0tCiBzcmMvdGVzdC9yZWdyZXNzL3NxbC9ob3JvbG9neS5zcWwgICAgICB8 ICA0ICsrLS0KIDMgZmlsZXMgY2hhbmdlZCwgMjQgaW5zZXJ0aW9ucygrKSwg MTIgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvc3JjL2JhY2tlbmQvdXRp bHMvYWR0L2Zvcm1hdHRpbmcuYyBiL3NyYy9iYWNrZW5kL3V0aWxzL2FkdC9m b3JtYXR0aW5nLmMKaW5kZXggYWU5M2ZlMC4uY2NhY2MwOSAxMDA2NDQKLS0t IGEvc3JjL2JhY2tlbmQvdXRpbHMvYWR0L2Zvcm1hdHRpbmcuYworKysgYi9z cmMvYmFja2VuZC91dGlscy9hZHQvZm9ybWF0dGluZy5jCkBAIC0yOTU1LDEx ICsyOTU1LDIzIEBAIERDSF9mcm9tX2NoYXIoRm9ybWF0Tm9kZSAqbm9kZSwg Y2hhciAqaW4sIFRtRnJvbUNoYXIgKm91dCkKIAkJaWYgKG4tPnR5cGUgIT0g Tk9ERV9UWVBFX0FDVElPTikKIAkJewogCQkJLyoKLQkJCSAqIFNlcGFyYXRv ciwgc28gY29uc3VtZSBvbmUgY2hhcmFjdGVyIGZyb20gaW5wdXQgc3RyaW5n LiAgTm90aWNlCi0JCQkgKiB3ZSBkb24ndCBpbnNpc3QgdGhhdCB0aGUgY29u c3VtZWQgY2hhcmFjdGVyIG1hdGNoIHRoZSBmb3JtYXQncwotCQkJICogY2hh cmFjdGVyLgorCQkJICogSWdub3JlIHNwYWNlcyB3aGVuIG5vdCBpbiBGWCAo Zml4ZWQgd2lkdGgpIG1vZGUgYW5kIHNwYWNlIGluCisJCQkgKiB0aGUgZm9y bWF0IHN0cmluZy4KIAkJCSAqLwotCQkJcysrOworCQkJaWYgKCFmeF9tb2Rl ICYmIGlzc3BhY2UoKHVuc2lnbmVkIGNoYXIpIG4tPmNoYXJhY3RlcikpCisJ CQl7CisJCQkJd2hpbGUgKCpzICE9ICdcMCcgJiYgaXNzcGFjZSgodW5zaWdu ZWQgY2hhcikgKnMpKQorCQkJCQlzKys7CisJCQl9CisJCQllbHNlCisJCQl7 CisJCQkJLyoKKwkJCQkgKiBTZXBhcmF0b3IsIHNvIGNvbnN1bWUgb25lIGNo YXJhY3RlciBmcm9tIGlucHV0IHN0cmluZy4KKwkJCQkgKiBOb3RpY2Ugd2Ug ZG9uJ3QgaW5zaXN0IHRoYXQgdGhlIGNvbnN1bWVkIGNoYXJhY3RlciBtYXRj aAorCQkJCSAqIHRoZSBmb3JtYXQncyBjaGFyYWN0ZXIuCisJCQkJICovCisJ CQkJcysrOworCQkJfQogCQkJY29udGludWU7CiAJCX0KIApkaWZmIC0tZ2l0 IGEvc3JjL3Rlc3QvcmVncmVzcy9leHBlY3RlZC9ob3JvbG9neS5vdXQgYi9z cmMvdGVzdC9yZWdyZXNzL2V4cGVjdGVkL2hvcm9sb2d5Lm91dAppbmRleCAx ZmUwMmJlLi45OGE5NjgxIDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNz L2V4cGVjdGVkL2hvcm9sb2d5Lm91dAorKysgYi9zcmMvdGVzdC9yZWdyZXNz L2V4cGVjdGVkL2hvcm9sb2d5Lm91dApAQCAtMjc3Niw3ICsyNzc2LDcgQEAg U0VMRUNUIHRvX3RpbWVzdGFtcCgnMTk4NSBKYW51YXJ5IDEyJywgJ1lZWVkg Rk1Nb250aCBERCcpOwogKDEgcm93KQogCiBTRUxFQ1QgdG9fdGltZXN0YW1w KCdNeSBiaXJ0aGRheS0+IFllYXI6IDE5NzYsIE1vbnRoOiBNYXksIERheTog MTYnLAotICAgICAgICAgICAgICAgICAgICAnIk15IGJpcnRoZGF5LT4gWWVh ciIgWVlZWSwgIk1vbnRoOiIgRk1Nb250aCwgIkRheToiIEREJyk7CisgICAg ICAgICAgICAgICAgICAgICciTXkgYmlydGhkYXktPiBZZWFyOiIgWVlZWSwg Ik1vbnRoOiIgRk1Nb250aCwgIkRheToiIEREJyk7CiAgICAgICAgICB0b190 aW1lc3RhbXAgICAgICAgICAKIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQogIFN1biBNYXkgMTYgMDA6MDA6MDAgMTk3NiBQRFQKQEAgLTI3ODks NyArMjc4OSw3IEBAIFNFTEVDVCB0b190aW1lc3RhbXAoJzEsNTgybmQgVklJ SSAyMScsICdZLFlZWXRoIEZNUk0gREQnKTsKICgxIHJvdykKIAogU0VMRUNU IHRvX3RpbWVzdGFtcCgnMTUgInRleHQgYmV0d2VlbiBxdW90ZSBtYXJrcyIg OTggNTQgNDUnLAotICAgICAgICAgICAgICAgICAgICBFJ0hIMjQgIlxcdGV4 dCBiZXR3ZWVuIHF1b3RlIG1hcmtzXFwiIiBZWSBNSSBTUycpOworICAgICAg ICAgICAgICAgICAgICBFJ0hIMjQgIlxcInRleHQgYmV0d2VlbiBxdW90ZSBt YXJrc1xcIiIgWVkgTUkgU1MnKTsKICAgICAgICAgIHRvX3RpbWVzdGFtcCAg ICAgICAgIAogLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tCiAgVGh1 IEphbiAwMSAxNTo1NDo0NSAxOTk4IFBTVApAQCAtMjkxMiw3ICsyOTEyLDcg QEAgU0VMRUNUIHRvX3RpbWVzdGFtcCgnICAyMDA1MDMwMicsICdZWVlZTU1E RCcpOwogU0VMRUNUIHRvX3RpbWVzdGFtcCgnMjAxMS0xMi0xOCAyMzozODox NScsICdZWVlZLU1NLUREICBISDI0Ok1JOlNTJyk7CiAgICAgICAgICB0b190 aW1lc3RhbXAgICAgICAgICAKIC0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLQotIFN1biBEZWMgMTggMDM6Mzg6MTUgMjAxMSBQU1QKKyBTdW4gRGVj IDE4IDIzOjM4OjE1IDIwMTEgUFNUCiAoMSByb3cpCiAKIFNFTEVDVCB0b190 aW1lc3RhbXAoJzIwMTEtMTItMTggIDIzOjM4OjE1JywgJ1lZWVktTU0tREQg IEhIMjQ6TUk6U1MnKTsKQEAgLTI5NDIsNyArMjk0Miw3IEBAIFNFTEVDVCB0 b190aW1lc3RhbXAoJzIwMTEtMTItMTggIDIzOjM4OjE1JywgJ1lZWVktTU0t REQgIEhIMjQ6TUk6U1MnKTsKIFNFTEVDVCB0b190aW1lc3RhbXAoJzIwMTEt MTItMTggIDIzOjM4OjE1JywgJ1lZWVktTU0tREQgICBISDI0Ok1JOlNTJyk7 CiAgICAgICAgICB0b190aW1lc3RhbXAgICAgICAgICAKIC0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQotIFN1biBEZWMgMTggMDM6Mzg6MTUgMjAx MSBQU1QKKyBTdW4gRGVjIDE4IDIzOjM4OjE1IDIwMTEgUFNUCiAoMSByb3cp CiAKIFNFTEVDVCB0b19kYXRlKCcyMDExIDEyICAxOCcsICdZWVlZIE1NIERE Jyk7CkBAIC0yOTYwLDEzICsyOTYwLDEzIEBAIFNFTEVDVCB0b19kYXRlKCcy MDExIDEyICAxOCcsICdZWVlZIE1NICBERCcpOwogU0VMRUNUIHRvX2RhdGUo JzIwMTEgMTIgIDE4JywgJ1lZWVkgTU0gICBERCcpOwogICB0b19kYXRlICAg CiAtLS0tLS0tLS0tLS0KLSAxMi0wOC0yMDExCisgMTItMTgtMjAxMQogKDEg cm93KQogCiBTRUxFQ1QgdG9fZGF0ZSgnMjAxMSAxMiAxOCcsICdZWVlZICBN TSBERCcpOwogICB0b19kYXRlICAgCiAtLS0tLS0tLS0tLS0KLSAwMi0xOC0y MDExCisgMTItMTgtMjAxMQogKDEgcm93KQogCiBTRUxFQ1QgdG9fZGF0ZSgn MjAxMSAgMTIgMTgnLCAnWVlZWSAgTU0gREQnKTsKZGlmZiAtLWdpdCBhL3Ny Yy90ZXN0L3JlZ3Jlc3Mvc3FsL2hvcm9sb2d5LnNxbCBiL3NyYy90ZXN0L3Jl Z3Jlc3Mvc3FsL2hvcm9sb2d5LnNxbAppbmRleCBjODE0MzdiLi43MWYwYWNm IDEwMDY0NAotLS0gYS9zcmMvdGVzdC9yZWdyZXNzL3NxbC9ob3JvbG9neS5z cWwKKysrIGIvc3JjL3Rlc3QvcmVncmVzcy9zcWwvaG9yb2xvZ3kuc3FsCkBA IC0zOTUsMTIgKzM5NSwxMiBAQCBTRUxFQ1QgdG9fdGltZXN0YW1wKCc5Ny8y LzE2IDg6MTQ6MzAnLCAnRk1ZWVlZL0ZNTU0vRk1ERCBGTUhIOkZNTUk6Rk1T UycpOwogU0VMRUNUIHRvX3RpbWVzdGFtcCgnMTk4NSBKYW51YXJ5IDEyJywg J1lZWVkgRk1Nb250aCBERCcpOwogCiBTRUxFQ1QgdG9fdGltZXN0YW1wKCdN eSBiaXJ0aGRheS0+IFllYXI6IDE5NzYsIE1vbnRoOiBNYXksIERheTogMTYn LAotICAgICAgICAgICAgICAgICAgICAnIk15IGJpcnRoZGF5LT4gWWVhciIg WVlZWSwgIk1vbnRoOiIgRk1Nb250aCwgIkRheToiIEREJyk7CisgICAgICAg ICAgICAgICAgICAgICciTXkgYmlydGhkYXktPiBZZWFyOiIgWVlZWSwgIk1v bnRoOiIgRk1Nb250aCwgIkRheToiIEREJyk7CiAKIFNFTEVDVCB0b190aW1l c3RhbXAoJzEsNTgybmQgVklJSSAyMScsICdZLFlZWXRoIEZNUk0gREQnKTsK IAogU0VMRUNUIHRvX3RpbWVzdGFtcCgnMTUgInRleHQgYmV0d2VlbiBxdW90 ZSBtYXJrcyIgOTggNTQgNDUnLAotICAgICAgICAgICAgICAgICAgICBFJ0hI MjQgIlxcdGV4dCBiZXR3ZWVuIHF1b3RlIG1hcmtzXFwiIiBZWSBNSSBTUycp OworICAgICAgICAgICAgICAgICAgICBFJ0hIMjQgIlxcInRleHQgYmV0d2Vl biBxdW90ZSBtYXJrc1xcIiIgWVkgTUkgU1MnKTsKIAogU0VMRUNUIHRvX3Rp bWVzdGFtcCgnMDUxMjE0NDU0ODIwMDAnLCAnTU1EREhIMjRNSVNTWVlZWScp OwogCi0tIAoyLjYuMgoK ------=_Part_2692377_1985140396.1465983221272 Content-Type: text/plain Content-Disposition: inline Content-Transfer-Encoding: 8bit MIME-Version: 1.0 -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers ------=_Part_2692377_1985140396.1465983221272--