From: =?ISO-8859-1?Q?C=E9dric?= Villemain <cedric@2ndquadrant.com>
To: Andrew Dunstan <andrew@dunslane.net>
Reply-To: cedric@2ndquadrant.com
Cc: pgsql-hackers@postgresql.org, Josh Berkus <josh@agliodbs.com>,
 Robert Haas <robertmhaas@gmail.com>, Peter Eisentraut <peter_e@gmx.net>,
 Craig Ringer <craig@2ndquadrant.com>
Subject: Re: Bugfix and new feature for PGXS
Date: Mon, 30 Sep 2013 08:50:38 +0200
Message-ID: <41858909.8rl4vTGUkV@obelix>
Organization: 2ndQuadrant France
User-Agent: KMail/4.10.5 (Linux/3.10-3-rt-amd64; KDE/4.10.5; x86_64; ; )
In-Reply-To: <5248F9A1.1000002@dunslane.net>
References: <201306181552.36673.cedric@2ndquadrant.com>
 <5248B32E.1090001@dunslane.net> <5248F9A1.1000002@dunslane.net>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="nextPart1654752.CgR1WUTE9x";
 micalg="pgp-sha1"; protocol="application/pgp-signature"
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org


--nextPart1654752.CgR1WUTE9x
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="UTF-8"

Le lundi 30 septembre 2013 00:10:09 Andrew Dunstan a =C3=A9crit :
> On 09/29/2013 07:09 PM, Andrew Dunstan wrote:
> > On 09/03/2013 04:04 AM, C=C3=A9dric Villemain wrote:
> >>> Simple one, attached.
> >>> I didn't document USE_VPATH, not sure how to explain that clearly=
.
> >>=20
> >> Just a remember that the doc is written and is waiting to be
> >> commited.
> >>=20
> >> There is also an issue spoted by Christoph with the installdirs
> >> prerequisite,
> >> the attached patch fix that.
> >=20
> > I applied this one line version of the patch, which seemed more
> > elegant than the later one supplied.
> >=20
> > I backpatched that and the rest of the VPATH changes for extensiuon=
s
> > to 9.1 where we first provided for extensions, so people can have a=

> > reasonably uniform build system for their extensions.
>=20
> I have reverted this in the 9.2 and 9.1 branches until I can work out=

> why it's breaking the buildfarm. 9.3 seems to be fine.

Yes, please take the longer but better patch following the small one.=20=

There are eveidences that it fixes compilation to always build=20
installdirs first.
Previously installdirs may be build after copying files, so it fails.
Chritstoph authored this good patch.

I'm sorry not to have been clear on that.
--=20
C=C3=A9dric Villemain +33 (0)6 20 30 22 52
http://2ndQuadrant.fr/
PostgreSQL: Support 24x7 - D=C3=A9veloppement, Expertise et Formation
--nextPart1654752.CgR1WUTE9x
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part.
Content-Transfer-Encoding: 7Bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.21 (GNU/Linux)

iQEcBAABAgAGBQJSSR9BAAoJENsgH0yzVBebIWsH/390E/PAVJaRS3W0l2suIAXN
94QDW9QgIEV/FtLMrBDKlGxpqnSU3/i7TO6P34Aih9nFx8Ryl8cVoc61n4C0pg0W
uu/W3r3s6YPktrQb1KG9QiS8Oj/n1d0Dn/NJ08dLdXCX9vQB2O+eIGpGdaZxHzbC
B59AR1t+kFikARMwFvp2AjaJooItwJ6mgYWosnZhoN6v156zi3zH0kqo06K+3Cgp
kMqjF9kLlffd78/mIPLk9bEa4WyRoLpxfn2QOkAST7xkVvNGCmsPqPYPljAOm1qM
BZahT9aos6R03kqZs7YIVVN27vwzMz/lyEzc4xUuwAVc2b+Pkcl1QnfdVSn7hDM=
=J7v2
-----END PGP SIGNATURE-----

--nextPart1654752.CgR1WUTE9x--