From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: pgsql-hackers@postgresql.org
Subject: Re: Declaration fixes
In-reply-to: <20220512164513.vaheofqp2q24l65r@alap3.anarazel.de>
References: <20220512164513.vaheofqp2q24l65r@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Thu, 12 May 2022 09:45:13 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <418903.1652375885.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Thu, 12 May 2022 13:18:05 -0400
Message-ID: <418904.1652375885@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/418904.1652375885%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> I was experimenting with specifying symbol visiblity for functions expli=
citly,
> i.e. adding PGDLLIMPORT markers for them, with the goal of getting rid o=
f
> src/tools/msvc/gendef.pl (and similar AIX stuff). While doing that I com=
pared
> the set of exported symbols before / after, leading me to find a few
> pre-existing "issues".

> I think the attached patches are all a good idea and trivial enought tha=
t I
> think we should apply them now.

+1 to all of that.  Would the changes you're working on result in getting
warnings for these sorts of oversights on mainstream compilers?

			regards, tom lane