public inbox for [email protected]  

help / color / mirror / Atom feed

From: Andrew Dunstan <[email protected]>
To: Dagfinn Ilmari Mannsåker <[email protected]>
To: Ashutosh Bapat <[email protected]>
Cc: Peter Smith <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: TAP test command_fails versus command_fails_like
Date: Wed, 12 Feb 2025 10:40:25 -0500
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAHut+Pu-umU=CkcSvrqL9eQt85Rv_qfLtekqU-yrjfh=GirUQg@mail.gmail.com>
	<CAExHW5vMkqvgxXOveB0_uRjYiCY319HK83Y-ErehcLyE0yv9Ww@mail.gmail.com>
	<[email protected]>


On 2025-02-12 We 8:58 AM, Dagfinn Ilmari Mannsåker wrote:
>
>> Another question is whether command_fails and command_fails_like is
>> the only pair or there are more which need stricter checks?
> If we do this, we should do it across the board for
> PostgreSQL::Test::Utils and ::Cluster at least.  Once we bump the
> minimum perl version to 5.20 or beyond we should switch to using
> function signatures (https://perldoc.perl.org/perlsub#Signatures), which
> gives us this checking for free.
>

Is there any reason we can't move to 5.20? Are there any buildfarm 
animals using such an old version? 5.20 is now almost 10 years old.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com

view thread (6+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: TAP test command_fails versus command_fails_like
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox