Content-Type: text/plain;
	charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\))
Subject: Re: Fix REPACK with WITHOUT OVERLAPS replica identity indexes
From: Chao Li <li.evan.chao@gmail.com>
In-Reply-To: <agIBukr85PlM6um_@alvherre.pgsql>
Date: Tue, 12 May 2026 10:31:05 +0800
Cc: Kirill Reshke <reshkekirill@gmail.com>,
 PostgreSQL-development <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <41CE1664-61E0-4857-A27A-924A6AD42B11@gmail.com>
References: <agIBukr85PlM6um_@alvherre.pgsql>
To: =?utf-8?Q?=C3=81lvaro_Herrera?= <alvherre@kurilemu.de>
Archived-At: 
 <https://www.postgresql.org/message-id/41CE1664-61E0-4857-A27A-924A6AD42B11%40gmail.com>
Precedence: bulk


> On May 12, 2026, at 00:21, =C3=81lvaro Herrera <alvherre@kurilemu.de> =
wrote:
>=20
> On 2026-May-11, Chao Li wrote:
>=20
>>> On May 10, 2026, at 06:38, =C3=81lvaro Herrera =
<alvherre@kurilemu.de> wrote:
>=20
>>> I think it would be a good idea to make identity_key_equal() not =
deform
>>> all attributes, but instead only up to the last one it needs for the =
key
>>> comparisons.
>>=20
>> That=E2=80=99s true. Please see v3.
>=20
> Thanks.  I did one further small change, namely to determine these =
last
> attnums just once per run rather than once per tuple.  Pushed now.
>=20
> Thanks for testing!
>=20
> --=20
> =C3=81lvaro Herrera               48=C2=B001'N 7=C2=B057'E  =E2=80=94  =
https://www.EnterpriseDB.com/

Hi =C3=81lvaro, thank you so much for tuning the code and pushing.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/