Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owly6-00040T-Hc for pgsql-hackers@arkaria.postgresql.org; Sun, 20 Nov 2022 15:10:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1owly5-0006KU-BY for pgsql-hackers@arkaria.postgresql.org; Sun, 20 Nov 2022 15:10:49 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owly5-0006KK-2h for pgsql-hackers@lists.postgresql.org; Sun, 20 Nov 2022 15:10:49 +0000 Received: from relay11.mail.gandi.net ([2001:4b98:dc4:8::231]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1owly0-0001Qd-Oz for pgsql-hackers@postgresql.org; Sun, 20 Nov 2022 15:10:48 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 43FE2100002; Sun, 20 Nov 2022 15:10:39 +0000 (UTC) Message-ID: <41ba523e-c867-2c04-3c34-d283a6ba9f7b@dunslane.net> Date: Sun, 20 Nov 2022 10:10:38 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: ssl tests aren't concurrency safe due to get_free_port() Content-Language: en-US To: Andres Freund Cc: pgsql-hackers@postgresql.org, Tom Lane References: <20221002164931.d57hlutrcz4d2zi7@awork3.anarazel.de> <7579f627-aad4-7a04-1a98-033cc6b3cca5@dunslane.net> <52266bf8-bf38-fdfa-9a77-1568f82b63b3@dunslane.net> <0891f64a-d30f-a1b7-9d0c-e447684cd8cd@dunslane.net> <20221105183643.v2nxsac3xlb3eazi@awork3.anarazel.de> <0867ca05-ed3f-09ca-cd41-d7087e542362@dunslane.net> <20221116015105.g6qxu2ugpj6agt26@awork3.anarazel.de> <58de442f-a4fb-3980-85c8-a024ff26c54b@dunslane.net> <20221119201615.uy4rvspdq62oqikn@awork3.anarazel.de> From: Andrew Dunstan In-Reply-To: <20221119201615.uy4rvspdq62oqikn@awork3.anarazel.de> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2022-11-19 Sa 15:16, Andres Freund wrote: > Hi, > > On 2022-11-19 10:56:33 -0500, Andrew Dunstan wrote: >>> Perhaps we should just export a directory in configure instead of this >>> guessing game? >> I think the obvious candidate would be to export top_builddir from >> src/Makefile.global. That would remove the need to infer it from >> TESTDATADIR. > I think that'd be good. I'd perhaps rename it in the process so it's > exported uppercase, but whatever... > OK, pushed with a little more tweaking. I didn't upcase top_builddir because the existing prove_installcheck recipes already export it and I wanted to stay consistent with those. If it works ok I will backpatch in couple of days. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com