Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qyP0P-008Agg-IO for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Nov 2023 04:08:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qyP0N-00AtGo-LU for pgsql-hackers@arkaria.postgresql.org; Thu, 02 Nov 2023 04:08:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qyP0N-00AtGg-7x for pgsql-hackers@lists.postgresql.org; Thu, 02 Nov 2023 04:08:27 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by magus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qyP0H-004GcE-U3 for pgsql-hackers@lists.postgresql.org; Thu, 02 Nov 2023 04:08:26 +0000 Received: from [192.168.100.8] (109-252-88-77.nat.spd-mgts.ru [109.252.88.77]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: a.melnikov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id A9B7AE20E5A; Thu, 2 Nov 2023 07:08:20 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1698898100; bh=tuFnhqUPfAt85FSiKePlMTCdLhvcUbUJOoMupip1Aig=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=Fz6RMVKqVefX9TeZnnItPcZnu2W9Y1rv51yspBP0qdiieBrZh4/578SMJe/Ba9CgL YYk05IivjBs1LR9s7rjL/X+GoiMv6FoucR0SRjjhO8UIiCT0uYQ2ys+24jJfrGMOyO 5rGiZMMTaop2v5hF81TbmeoSiVWe31CSC5LM50oo2OuwMLTZytoG4icgIk+V2ZhObe EnQS+ytZSoo+OLyO+pt6pGJ1PnuyNde49NPtHehAn6ayq5U6BTswwlEhf15lLeAhwN gg0x1ftZvORSi9HiQA6oUz//VRX/xzPwcNbCkn5qECoCBa7Erwh8V0F6k6dS5hIMUo u9QJPIZCLSJ9w== Message-ID: <41dddabd-e671-41dc-8915-6ea709744955@postgrespro.ru> Date: Thu, 2 Nov 2023 07:08:20 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: 003_check_guc.pl crashes if some extensions were loaded. Content-Language: en-US To: Tom Lane , Michael Paquier Cc: PostgreSQL Hackers References: <2885775.1698881391@sss.pgh.pa.us> From: "Anton A. Melnikov" In-Reply-To: <2885775.1698881391@sss.pgh.pa.us> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 02.11.2023 01:53, Michael Paquier wrote:> On Thu, Nov 02, 2023 at 12:28:05AM +0300, Anton A. Melnikov wrote: >> Found that src/test/modules/test_misc/t/003_check_guc.pl will crash if an extension >> that adds own GUCs was loaded into memory. >> So it is now impossible to run a check-world with loaded extension libraries. > > Right. That's annoying, so let's fix it. Thanks! On 02.11.2023 02:29, Tom Lane wrote: > Michael Paquier writes: >> Wouldn't it be better to add a qual as of "category <> 'Customized >> Options'"? > > +1, seems like a cleaner answer. Also agreed. That is a better variant! -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company