public inbox for [email protected]  

help / color / mirror / Atom feed

From: Peter Eisentraut <[email protected]>
To: jian he <[email protected]>
Cc: pgsql-hackers <[email protected]>
Cc: Dean Rasheed <[email protected]>
Subject: Re: Virtual generated columns
Date: Tue, 12 Nov 2024 17:08:16 +0100
Message-ID: <[email protected]> (raw)
In-Reply-To: <CACJufxF8fmM=Dbm4pDFuV_nKGz2-No0k4YifhrF3-rjXTWJM3w@mail.gmail.com>
References: <[email protected]>
	<CACJufxE+E-iYmBnZVZHiYA+WpyZZVv7BfiBLpo=T70EZHDU9rw@mail.gmail.com>
	<[email protected]>
	<CACJufxGh=XX7q5xTci---HikSJsOwP7_qCNyyDHdp2YL4NLZCg@mail.gmail.com>
	<CACJufxHxoz_KVQxcQ=cSvJc+PNbh=FaHbcMZCOisoOaGAgjy4w@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAEZATCV=RX0M58-uqSR6tFjwQAFnEcx3hvW-9ZZfRQJLg5LzRw@mail.gmail.com>
	<[email protected]>
	<CAEZATCU3q=znAL7X1aSxuMpjfSyB1cT5j398HPb9ix9ci_HUqA@mail.gmail.com>
	<[email protected]>
	<CAEZATCVLfMzNwT1J0bnvtv6YbmNSN9QSXb+1QSGyX6vK4q67Ow@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<CACJufxF8fmM=Dbm4pDFuV_nKGz2-No0k4YifhrF3-rjXTWJM3w@mail.gmail.com>

On 11.11.24 12:37, jian he wrote:
> On Wed, Nov 6, 2024 at 12:17 AM Peter Eisentraut <[email protected]> wrote:
>>
>> New patch version.  I've gone through the whole thread again and looked
>> at all the feedback and various bug reports and test cases and made sure
>> they are all addressed in the latest patch version.  (I'll send some
>> separate messages to respond to some individual messages, but I'm
>> keeping the latest patch here.)
> 
> just quickly note the not good error message before you rebase.
> 
> src7=# create domain d_fail as int4 constraint cc GENERATED ALWAYS AS (2) ;
> ERROR:  unrecognized constraint subtype: 4
> src7=# create domain d_fail as int4 constraint cc GENERATED ALWAYS AS
> (2) stored;
> ERROR:  unrecognized constraint subtype: 4
> src7=# create domain d_fail as int4 constraint cc GENERATED ALWAYS AS
> (2) virtual;
> ERROR:  unrecognized constraint subtype: 4
> 
> reading gram.y, typedef struct Constraint seems cannot distinguish, we
> are creating a domain or create table.
> I cannot found a way to error out in gram.y.
> 
> so we have to error out at DefineDomain.

This appears to be a very old problem independent of this patch.  I'll 
take a look at fixing it.

view thread (75+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: Virtual generated columns
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox