Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uJked-005ap9-PS for pgsql-hackers@arkaria.postgresql.org; Tue, 27 May 2025 03:07:04 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1uJkea-005X23-D7 for pgsql-hackers@arkaria.postgresql.org; Tue, 27 May 2025 03:07:00 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1uJkeZ-005X1v-Ee for pgsql-hackers@lists.postgresql.org; Tue, 27 May 2025 03:07:00 +0000 Received: from mail-m16.yeah.net ([220.197.32.17]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1uJkeS-000IJH-3A for pgsql-hackers@postgresql.org; Tue, 27 May 2025 03:06:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yeah.net; s=s110527; h=Content-Type:Message-ID:Date:MIME-Version:To:From: Subject; bh=5oVqTHS5dhv+3G7BSdnWrOEmJ3TqWLdfQF2/yO4yfq8=; b=eUqP mh00C23igi1i3HbKuPSsAiwWzBnrbs481D+l21oHxMwoeTeA8U3fIxQuBL3d92is bhnny0+rlniWCkAWc3dA2sl4eHDm11FEa5BgRDiQjjgy2ADfuqTyQtXoRj4l99nL BAiPGpaKoRrSzEi7YZpXkkdQDfp0QOxyrHr+Yd8= Received: from [192.168.10.60] (unknown []) by gzsmtp2 (Coremail) with SMTP id Ms8vCgD308hHLDVofxjlAQ--.32931S2; Tue, 27 May 2025 11:06:48 +0800 (CST) Content-Type: multipart/mixed; boundary="------------7dGe2SIDl0Y3wcuZO9KX306Z" Message-ID: <41ff310b-16bd-44b9-a3ef-97e20f14b709@yeah.net> Date: Tue, 27 May 2025 11:06:46 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Content-Language: en-US To: pgsql-hackers From: Quan Zongliang Subject: Standardize the definition of the subtype field of AlterDomainStmt X-CM-TRANSID: Ms8vCgD308hHLDVofxjlAQ--.32931S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrGr1UXFyxGr1fXrW7CF15Jwb_yoWxXwcE9r WSgr17tw1UCFykta97Gr4fGa9rCr4Y9r17Jr1DXr98J3yrKrZ7XrZY9ryxZr1fXa1fAF9x tFyqyw1Yy3WDujkaLaAFLSUrUUUUjb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUnUGYPUUUUU== X-Originating-IP: [117.13.75.128] X-CM-SenderInfo: htxd06xrqjzxxdqjq5hhdkh0dhw/1tbiERZaJGg1JygaegAAsL List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------7dGe2SIDl0Y3wcuZO9KX306Z Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I noticed that the subtype of AlterDomainStmt is directly using constants in the code. It is not conducive to the maintenance and reading of the code. Based on the definition of AlterTableType, use "AD_" as the prefix. Define several macros to replace the original characters. The subtype of AlterTableCmd is defined using an enumeration. The subtypes of AlterDomainStmt are relatively few in number, and the original definition uses characters. These definitions still use characters and maintain the values unchanged. If some plugins or tools are also processing AlterDomainStmt, there will be no errors. -- Quan Zongliang --------------7dGe2SIDl0Y3wcuZO9KX306Z Content-Type: text/plain; charset=UTF-8; name="alterdomain_subtype.patch" Content-Disposition: attachment; filename="alterdomain_subtype.patch" Content-Transfer-Encoding: base64 ZGlmZiAtLWdpdCBhL3NyYy9iYWNrZW5kL2NvbW1hbmRzL3RhYmxlY21kcy5jIGIvc3JjL2Jh Y2tlbmQvY29tbWFuZHMvdGFibGVjbWRzLmMKaW5kZXggNTRhZDM4MjQ3YWEuLjNmMDlmODVh NDgwIDEwMDY0NAotLS0gYS9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYworKysg Yi9zcmMvYmFja2VuZC9jb21tYW5kcy90YWJsZWNtZHMuYwpAQCAtMTU2OTYsNyArMTU2OTYs NyBAQCBBVFBvc3RBbHRlclR5cGVQYXJzZShPaWQgb2xkSWQsIE9pZCBvbGRSZWxJZCwgT2lk IHJlZlJlbElkLCBjaGFyICpjbWQsCiAJCXsKIAkJCUFsdGVyRG9tYWluU3RtdCAqc3RtdCA9 IChBbHRlckRvbWFpblN0bXQgKikgc3RtOwogCi0JCQlpZiAoc3RtdC0+c3VidHlwZSA9PSAn QycpCS8qIEFERCBDT05TVFJBSU5UICovCisJCQlpZiAoc3RtdC0+c3VidHlwZSA9PSBBRF9B ZGRDb25zdHJhaW50KQogCQkJewogCQkJCUNvbnN0cmFpbnQgKmNvbiA9IGNhc3ROb2RlKENv bnN0cmFpbnQsIHN0bXQtPmRlZik7CiAJCQkJQWx0ZXJUYWJsZUNtZCAqY21kID0gbWFrZU5v ZGUoQWx0ZXJUYWJsZUNtZCk7CmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC9wYXJzZXIvZ3Jh bS55IGIvc3JjL2JhY2tlbmQvcGFyc2VyL2dyYW0ueQppbmRleCAwYjU2NTIwNzFkMS4uMzkx ZTcwYjU5NGMgMTAwNjQ0Ci0tLSBhL3NyYy9iYWNrZW5kL3BhcnNlci9ncmFtLnkKKysrIGIv c3JjL2JhY2tlbmQvcGFyc2VyL2dyYW0ueQpAQCAtMTE2MjksNyArMTE2MjksNyBAQCBBbHRl ckRvbWFpblN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0bXQgKm4gPSBtYWtlTm9k ZShBbHRlckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUgPSAnVCc7CisJCQkJCW4t PnN1YnR5cGUgPSBBRF9BbHRlckRlZmF1bHQ7CiAJCQkJCW4tPnR5cGVOYW1lID0gJDM7CiAJ CQkJCW4tPmRlZiA9ICQ0OwogCQkJCQkkJCA9IChOb2RlICopIG47CkBAIC0xMTYzOSw3ICsx MTYzOSw3IEBAIEFsdGVyRG9tYWluU3RtdDoKIAkJCQl7CiAJCQkJCUFsdGVyRG9tYWluU3Rt dCAqbiA9IG1ha2VOb2RlKEFsdGVyRG9tYWluU3RtdCk7CiAKLQkJCQkJbi0+c3VidHlwZSA9 ICdOJzsKKwkJCQkJbi0+c3VidHlwZSA9IEFEX0Ryb3BOb3ROdWxsOwogCQkJCQluLT50eXBl TmFtZSA9ICQzOwogCQkJCQkkJCA9IChOb2RlICopIG47CiAJCQkJfQpAQCAtMTE2NDgsNyAr MTE2NDgsNyBAQCBBbHRlckRvbWFpblN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0 bXQgKm4gPSBtYWtlTm9kZShBbHRlckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUg PSAnTyc7CisJCQkJCW4tPnN1YnR5cGUgPSBBRF9TZXROb3ROdWxsOwogCQkJCQluLT50eXBl TmFtZSA9ICQzOwogCQkJCQkkJCA9IChOb2RlICopIG47CiAJCQkJfQpAQCAtMTE2NTcsNyAr MTE2NTcsNyBAQCBBbHRlckRvbWFpblN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0 bXQgKm4gPSBtYWtlTm9kZShBbHRlckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUg PSAnQyc7CisJCQkJCW4tPnN1YnR5cGUgPSBBRF9BZGRDb25zdHJhaW50OwogCQkJCQluLT50 eXBlTmFtZSA9ICQzOwogCQkJCQluLT5kZWYgPSAkNTsKIAkJCQkJJCQgPSAoTm9kZSAqKSBu OwpAQCAtMTE2NjcsNyArMTE2NjcsNyBAQCBBbHRlckRvbWFpblN0bXQ6CiAJCQkJewogCQkJ CQlBbHRlckRvbWFpblN0bXQgKm4gPSBtYWtlTm9kZShBbHRlckRvbWFpblN0bXQpOwogCi0J CQkJCW4tPnN1YnR5cGUgPSAnWCc7CisJCQkJCW4tPnN1YnR5cGUgPSBBRF9Ecm9wQ29uc3Ry YWludDsKIAkJCQkJbi0+dHlwZU5hbWUgPSAkMzsKIAkJCQkJbi0+bmFtZSA9ICQ2OwogCQkJ CQluLT5iZWhhdmlvciA9ICQ3OwpAQCAtMTE2NzksNyArMTE2NzksNyBAQCBBbHRlckRvbWFp blN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0bXQgKm4gPSBtYWtlTm9kZShBbHRl ckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUgPSAnWCc7CisJCQkJCW4tPnN1YnR5 cGUgPSBBRF9Ecm9wQ29uc3RyYWludDsKIAkJCQkJbi0+dHlwZU5hbWUgPSAkMzsKIAkJCQkJ bi0+bmFtZSA9ICQ4OwogCQkJCQluLT5iZWhhdmlvciA9ICQ5OwpAQCAtMTE2OTEsNyArMTE2 OTEsNyBAQCBBbHRlckRvbWFpblN0bXQ6CiAJCQkJewogCQkJCQlBbHRlckRvbWFpblN0bXQg Km4gPSBtYWtlTm9kZShBbHRlckRvbWFpblN0bXQpOwogCi0JCQkJCW4tPnN1YnR5cGUgPSAn Vic7CisJCQkJCW4tPnN1YnR5cGUgPSBBRF9WYWlkYXRlQ29uc3RyYWludDsKIAkJCQkJbi0+ dHlwZU5hbWUgPSAkMzsKIAkJCQkJbi0+bmFtZSA9ICQ2OwogCQkJCQkkJCA9IChOb2RlICop IG47CmRpZmYgLS1naXQgYS9zcmMvYmFja2VuZC90Y29wL3V0aWxpdHkuYyBiL3NyYy9iYWNr ZW5kL3Rjb3AvdXRpbGl0eS5jCmluZGV4IDI1ZmUzZDU4MDE2Li41YzBhNGViNTNjYiAxMDA2 NDQKLS0tIGEvc3JjL2JhY2tlbmQvdGNvcC91dGlsaXR5LmMKKysrIGIvc3JjL2JhY2tlbmQv dGNvcC91dGlsaXR5LmMKQEAgLTEzNDMsNyArMTM0Myw3IEBAIFByb2Nlc3NVdGlsaXR5U2xv dyhQYXJzZVN0YXRlICpwc3RhdGUsCiAJCQkJCSAqLwogCQkJCQlzd2l0Y2ggKHN0bXQtPnN1 YnR5cGUpCiAJCQkJCXsKLQkJCQkJCWNhc2UgJ1QnOgkvKiBBTFRFUiBET01BSU4gREVGQVVM VCAqLworCQkJCQkJY2FzZSBBRF9BbHRlckRlZmF1bHQ6CiAKIAkJCQkJCQkvKgogCQkJCQkJ CSAqIFJlY3Vyc2l2ZWx5IGFsdGVyIGNvbHVtbiBkZWZhdWx0IGZvciB0YWJsZSBhbmQsCkBA IC0xMzUzLDMwICsxMzUzLDMwIEBAIFByb2Nlc3NVdGlsaXR5U2xvdyhQYXJzZVN0YXRlICpw c3RhdGUsCiAJCQkJCQkJCUFsdGVyRG9tYWluRGVmYXVsdChzdG10LT50eXBlTmFtZSwKIAkJ CQkJCQkJCQkJCSAgIHN0bXQtPmRlZik7CiAJCQkJCQkJYnJlYWs7Ci0JCQkJCQljYXNlICdO JzoJLyogQUxURVIgRE9NQUlOIERST1AgTk9UIE5VTEwgKi8KKwkJCQkJCWNhc2UgQURfRHJv cE5vdE51bGw6CiAJCQkJCQkJYWRkcmVzcyA9CiAJCQkJCQkJCUFsdGVyRG9tYWluTm90TnVs bChzdG10LT50eXBlTmFtZSwKIAkJCQkJCQkJCQkJCSAgIGZhbHNlKTsKIAkJCQkJCQlicmVh azsKLQkJCQkJCWNhc2UgJ08nOgkvKiBBTFRFUiBET01BSU4gU0VUIE5PVCBOVUxMICovCisJ CQkJCQljYXNlIEFEX1NldE5vdE51bGw6CiAJCQkJCQkJYWRkcmVzcyA9CiAJCQkJCQkJCUFs dGVyRG9tYWluTm90TnVsbChzdG10LT50eXBlTmFtZSwKIAkJCQkJCQkJCQkJCSAgIHRydWUp OwogCQkJCQkJCWJyZWFrOwotCQkJCQkJY2FzZSAnQyc6CS8qIEFERCBDT05TVFJBSU5UICov CisJCQkJCQljYXNlIEFEX0FkZENvbnN0cmFpbnQ6CiAJCQkJCQkJYWRkcmVzcyA9CiAJCQkJ CQkJCUFsdGVyRG9tYWluQWRkQ29uc3RyYWludChzdG10LT50eXBlTmFtZSwKIAkJCQkJCQkJ CQkJCQkJIHN0bXQtPmRlZiwKIAkJCQkJCQkJCQkJCQkJICZzZWNvbmRhcnlPYmplY3QpOwog CQkJCQkJCWJyZWFrOwotCQkJCQkJY2FzZSAnWCc6CS8qIERST1AgQ09OU1RSQUlOVCAqLwor CQkJCQkJY2FzZSBBRF9Ecm9wQ29uc3RyYWludDoKIAkJCQkJCQlhZGRyZXNzID0KIAkJCQkJ CQkJQWx0ZXJEb21haW5Ecm9wQ29uc3RyYWludChzdG10LT50eXBlTmFtZSwKIAkJCQkJCQkJ CQkJCQkJICBzdG10LT5uYW1lLAogCQkJCQkJCQkJCQkJCQkgIHN0bXQtPmJlaGF2aW9yLAog CQkJCQkJCQkJCQkJCQkgIHN0bXQtPm1pc3Npbmdfb2spOwogCQkJCQkJCWJyZWFrOwotCQkJ CQkJY2FzZSAnVic6CS8qIFZBTElEQVRFIENPTlNUUkFJTlQgKi8KKwkJCQkJCWNhc2UgQURf VmFpZGF0ZUNvbnN0cmFpbnQ6CiAJCQkJCQkJYWRkcmVzcyA9CiAJCQkJCQkJCUFsdGVyRG9t YWluVmFsaWRhdGVDb25zdHJhaW50KHN0bXQtPnR5cGVOYW1lLAogCQkJCQkJCQkJCQkJCQkJ ICBzdG10LT5uYW1lKTsKZGlmZiAtLWdpdCBhL3NyYy9pbmNsdWRlL25vZGVzL3BhcnNlbm9k ZXMuaCBiL3NyYy9pbmNsdWRlL25vZGVzL3BhcnNlbm9kZXMuaAppbmRleCA0NjEwZmM2MTI5 My4uNzM0OTkxOGUzNWUgMTAwNjQ0Ci0tLSBhL3NyYy9pbmNsdWRlL25vZGVzL3BhcnNlbm9k ZXMuaAorKysgYi9zcmMvaW5jbHVkZS9ub2Rlcy9wYXJzZW5vZGVzLmgKQEAgLTI1MzQsMTQg KzI1MzQsNyBAQCB0eXBlZGVmIHN0cnVjdCBBbHRlckNvbGxhdGlvblN0bXQKIHR5cGVkZWYg c3RydWN0IEFsdGVyRG9tYWluU3RtdAogewogCU5vZGVUYWcJCXR5cGU7Ci0JY2hhcgkJc3Vi dHlwZTsJCS8qLS0tLS0tLS0tLS0tCi0JCQkJCQkJCSAqCVQgPSBhbHRlciBjb2x1bW4gZGVm YXVsdAotCQkJCQkJCQkgKglOID0gYWx0ZXIgY29sdW1uIGRyb3Agbm90IG51bGwKLQkJCQkJ CQkJICoJTyA9IGFsdGVyIGNvbHVtbiBzZXQgbm90IG51bGwKLQkJCQkJCQkJICoJQyA9IGFk ZCBjb25zdHJhaW50Ci0JCQkJCQkJCSAqCVggPSBkcm9wIGNvbnN0cmFpbnQKLQkJCQkJCQkJ ICotLS0tLS0tLS0tLS0KLQkJCQkJCQkJICovCisJY2hhcgkJc3VidHlwZTsJCS8qIHNlZSBB RF94eHggY29uc3RhbnRzIGJlbG93ICovCiAJTGlzdAkgICAqdHlwZU5hbWU7CQkvKiBkb21h aW4gdG8gd29yayBvbiAqLwogCWNoYXIJICAgKm5hbWU7CQkJLyogY29sdW1uIG9yIGNvbnN0 cmFpbnQgbmFtZSB0byBhY3Qgb24gKi8KIAlOb2RlCSAgICpkZWY7CQkJLyogZGVmaW5pdGlv biBvZiBkZWZhdWx0IG9yIGNvbnN0cmFpbnQgKi8KQEAgLTI1NDksNiArMjU0MiwxMyBAQCB0 eXBlZGVmIHN0cnVjdCBBbHRlckRvbWFpblN0bXQKIAlib29sCQltaXNzaW5nX29rOwkJLyog c2tpcCBlcnJvciBpZiBtaXNzaW5nPyAqLwogfSBBbHRlckRvbWFpblN0bXQ7CiAKKy8qIEFs dGVyRG9tYWluU3RtdCBhY3Rpb24gKi8KKyNkZWZpbmUgQURfQWx0ZXJEZWZhdWx0CQkJCSdU JwkJCS8qIFNFVHxEUk9QIERFRkFVTFQgKi8KKyNkZWZpbmUgQURfRHJvcE5vdE51bGwJCQkJ J04nCQkJLyogRFJPUCBOT1QgTlVMTCAqLworI2RlZmluZSBBRF9TZXROb3ROdWxsCQkJCSdP JwkJCS8qIFNFVCBOT1QgTlVMTCAqLworI2RlZmluZSBBRF9BZGRDb25zdHJhaW50CQkJJ0Mn CQkJLyogQUREIENPTlNUUkFJTlQgKi8KKyNkZWZpbmUgQURfRHJvcENvbnN0cmFpbnQJCQkn WCcJCQkvKiBEUk9QIENPTlNUUkFJTlQgKi8KKyNkZWZpbmUgQURfVmFpZGF0ZUNvbnN0cmFp bnQJCSdWJwkJCS8qIFZBTElEQVRFIENPTlNUUkFJTlQgKi8KIAogLyogLS0tLS0tLS0tLS0t LS0tLS0tLS0tLQogICoJCUdyYW50fFJldm9rZSBTdGF0ZW1lbnQK --------------7dGe2SIDl0Y3wcuZO9KX306Z--