Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m855K-0003yt-1H for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Jul 2021 18:12:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m855I-00029H-PI for pgsql-hackers@arkaria.postgresql.org; Mon, 26 Jul 2021 18:12:12 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m855I-000298-Fp for pgsql-hackers@lists.postgresql.org; Mon, 26 Jul 2021 18:12:12 +0000 Received: from mxout2.routing.net ([2a03:2900:1:a::b]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m855F-00034l-4J for pgsql-hackers@lists.postgresql.org; Mon, 26 Jul 2021 18:12:11 +0000 Received: from mxbox3.masterlogin.de (unknown [192.168.10.78]) by mxout2.routing.net (Postfix) with ESMTP id 0EBC25FD44; Mon, 26 Jul 2021 18:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailerdienst.de; s=20200217; t=1627323125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=W4++lA0qNPZS9DFJe1sa7/LBZjmEGdgskc4lyrd98KU=; b=fGKvnx9acOXIMjYjXDs4Pr6ui/vXh4XkOzm026OENXl9nqW1zK6vNcopwVNhgCNIPp3WTb zRkBBXQDsFadpgJj+Ia1bG3OrXNpEEbqCKpA2CToxg4DK3YL6Pu7/LnNy9kyfTSU24gekB dDkzgC59sQvaBuoA6wn4KSyhrbEr0DM= Received: from remote.index.de (p578a9a34.dip0.t-ipconnect.de [87.138.154.52]) by mxbox3.masterlogin.de (Postfix) with ESMTPSA id 7B8EE36071E; Mon, 26 Jul 2021 18:11:59 +0000 (UTC) Received: from acedia.index-gruppe.local (192.168.3.121) by acedia.index-gruppe.local (192.168.3.121) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Mon, 26 Jul 2021 20:11:28 +0200 Received: from acedia.index-gruppe.local ([fe80::d96c:8551:78c8:d947]) by acedia.index-gruppe.local ([fe80::d96c:8551:78c8:d947%13]) with mapi id 15.01.2176.014; Mon, 26 Jul 2021 20:11:28 +0200 From: Arne Roland To: Tom Lane , Alvaro Herrera CC: vignesh C , Zhihong Yu , Pg Hackers Subject: Re: Rename of triggers for partitioned tables Thread-Topic: Rename of triggers for partitioned tables Thread-Index: AQHWxEk1+rora/wutkWbcRQhC03q0KnbGQ2sgAAECBOATmSTgIBhAeKAgBDG6bOAACCNT4AAKOcAgAAj1kP///tHgIAEsSJngAHhzjCAhX9QJP//43kAgAAjD3T///1iAABXUKhwA1bKhQAABHSL9QDdrxEAAARjdxL///exAIABN1SAgAG0zACAASTOjIAACgeAgAAiw8X///GFAIAAVHKAgAQ04YCAAbq9AIAABrAAgAAiizs= Date: Mon, 26 Jul 2021 18:11:28 +0000 Message-ID: <4217d1f783704ef7b9261e89065c24f2@index.de> References: <202107261714.kuzrvstzrufh@alvherre.pgsql>,<171676.1627321096@sss.pgh.pa.us> In-Reply-To: <171676.1627321096@sss.pgh.pa.us> Accept-Language: en-US, de-DE Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.1.33] Content-Type: multipart/alternative; boundary="_000_4217d1f783704ef7b9261e89065c24f2indexde_" MIME-Version: 1.0 X-Mail-ID: b1ce2cc2-96c7-48fc-b98e-b60ba4ebc519 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk --_000_4217d1f783704ef7b9261e89065c24f2indexde_ Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable From: Tom Lane Sent: Monday, July 26, 2021 19:38 To: Alvaro Herrera Subject: Re: Rename of triggers for partitioned tables > Yeah, we don't support partial indexes on catalogs, and this example > doesn't make me feel like we ought to open that can of worms. I asked why such an index doesn't exists already. I guess that answers it. = I definitely don't want to push for supporting that, especially not knowing= what it entails. > But then maybe this function shouldn't assume there's only one match? I'd consider a duplication here a serious bug. That is pretty much catalog= corruption. Having two children within a single child table sounds like it= would break a lot of things. That being said this function is hardly performance critical. I don't know = whether throwing an elog indicating what's going wrong here would be worth = it. Regards Arne --_000_4217d1f783704ef7b9261e89065c24f2indexde_ Content-Type: text/html; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable
From: Tom Lane <tgl@sss.pgh.pa.us>
Sent: Monday, July 26, 20= 21 19:38
To: Alvaro Herrera
Subject: Re: Rename of triggers for partitioned tables
 
> Yeah, we don't support partial indexes on catalo= gs, and this example
> doesn't make me feel like we ought to open that can of worms.

I asked why such an index doesn't exists a= lready. I guess that answers it. I definitely don't want to push for suppor= ting that, especially not knowing what it entails.

> But then maybe this function shouldn't assume there's only one match?

 I'd conside= r a duplication here a serious bug. That is pretty much catalog corruption.= Having two children within a single child table sounds like it would break= a lot of things.

That being said t= his function is hardly performance critical. I don't know whether throwing = an elog indicating what's going wrong here would be worth it.=

Regards
Arne

--_000_4217d1f783704ef7b9261e89065c24f2indexde_--