Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6Ygn-0003hG-Tc for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Mar 2019 10:43:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1h6Ygm-0006Bk-LC for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Mar 2019 10:43:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6Ygm-00066L-8v for pgsql-hackers@lists.postgresql.org; Wed, 20 Mar 2019 10:43:16 +0000 Received: from mail.thelabyrinth.net ([45.56.70.56]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1h6Ygk-0001Yi-18 for pgsql-hackers@postgresql.org; Wed, 20 Mar 2019 10:43:15 +0000 Received: from Davids-MacBook.local (unknown [41.136.236.135]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dsteele) by mail.thelabyrinth.net (Postfix) with ESMTPSA id 1B87C5468B; Wed, 20 Mar 2019 10:43:11 +0000 (UTC) Subject: Re: Re: Planning counters in pg_stat_statements (using pgss_store) To: legrand legrand References: <6112091549979517@myt5-a323eb993ef7.qloud-c.yandex.net> <1550179299067-0.post@n3.nabble.com> <2205341550215950@sas1-cd55e40a6ba0.qloud-c.yandex.net> Cc: Sergei Kornilov , "pgsql-hackers@postgresql.org" From: David Steele Message-ID: <422d3baf-81d7-7292-91c5-50dd28cecfc8@pgmasters.net> Date: Wed, 20 Mar 2019 14:43:03 +0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.5.3 MIME-Version: 1.0 In-Reply-To: <2205341550215950@sas1-cd55e40a6ba0.qloud-c.yandex.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Hi PAscal, On 2/15/19 11:32 AM, Sergei Kornilov wrote: > Hi > >>>  +#define PG_STAT_STATEMENTS_COLS_V1_4 25 >> >> I thought it was needed when adding new columns, isn't it ? > > Yes, this is needed. I mean it should be PG_STAT_STATEMENTS_COLS_V1_8: because such change was made for 1.8 pg_stat_statements version. Same thing for other version-specific places. This patch has been waiting for an update for over a month. Do you know when you will have one ready? Should we move the release target to PG13? Regards, -- -David david@pgmasters.net