Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tiPQf-00FfNG-FL for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Feb 2025 02:58:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1tiPQd-000tWB-4z for pgsql-hackers@arkaria.postgresql.org; Thu, 13 Feb 2025 02:58:15 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1tiPQc-000tW2-Ly for pgsql-hackers@lists.postgresql.org; Thu, 13 Feb 2025 02:58:15 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96) (envelope-from ) id 1tiPQa-000VPp-0P for pgsql-hackers@postgresql.org; Thu, 13 Feb 2025 02:58:13 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mx2023; t=1739415488; bh=g8dGdNMsj0tl6lwEQW8rvzmzEpfCL6YB392dabJDtYw=; h=Message-ID:Date:User-Agent:Subject:To:Cc:References:From: In-Reply-To:From; b=tiecS40BeAb96s/T3YyDTVlCxSjb49aNKji+JqZJbDbefpr6XrX6THPxNg5Nq1MEd VEa2HtOHR4bU+84vNnLlIwcqq+4/PM+x0/UumVbmQWXA1ts0QEgSa5cdVTxZrqPX5h 5eHeTo+Ki2SCQ742BZOoF/KZv0K6dDkjIUwccPPrIt6FjrEZBs/4q9+aRe4GyVBCv9 LknZOP5LSiHtzG9O4BMRIOI5BRZnZj7dqxrNzYDXBfvRhFlm+dJyvxeltoSw6d0Q0r R/U1b04LStdwDqkY28sd/7aP3Qe8Whsa4jbvgXWKxpSIqF3U/xKxFkqY5NAL0Ira1q vJT3ANjqWmWow== Received: from [172.30.56.6] (unknown [213.171.56.12]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (Client did not present a certificate) (Authenticated sender: a.melnikov@postgrespro.ru) by mail.postgrespro.ru (Postfix/587) with ESMTPSA id 3EE885FFE8; Thu, 13 Feb 2025 05:58:08 +0300 (MSK) Message-ID: <42304488-65ce-4604-854e-2aaf3bc8f09d@postgrespro.ru> Date: Thu, 13 Feb 2025 05:58:07 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: Change GUC hashtable to use simplehash? To: John Naylor Cc: Tom Lane , Jeff Davis , Ants Aasma , Heikki Linnakangas , Junwang Zhao , jian he , Andres Freund , Gurjeet Singh , pgsql-hackers@postgresql.org References: <458350a908d9607f7fc2a15407f4405cc454c970.camel@j-davis.com> <2b0df3af97fac73a40aba16a58837e2cee594b1f.camel@j-davis.com> <0647027b-9c9a-4f16-8f7c-3f9f3eb9451e@postgrespro.ru> <1520769.1736991361@sss.pgh.pa.us> <16198d33-a4e2-46db-b6c3-494367f5816d@postgrespro.ru> <4c739718-27d6-44fe-9113-56a251c13275@postgrespro.ru> Content-Language: en-US From: "Anton A. Melnikov" In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-KSMG-AntiPhishing: NotDetected, bases: 2025/02/13 01:47:00 X-KSMG-AntiSpam-Interceptor-Info: not scanned X-KSMG-AntiSpam-Status: not scanned, disabled by settings X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.1.0.7854, bases: 2025/02/12 21:13:00 #27196983 X-KSMG-AntiVirus-Status: NotDetected, skipped X-KSMG-LinksScanning: not scanned, disabled by settings X-KSMG-Message-Action: skipped X-KSMG-Rule-ID: 1 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Hi, John! On 13.02.2025 04:49, John Naylor wrote: > On Thu, Feb 13, 2025 at 3:42 AM Anton A. Melnikov > wrote: >> On 29.01.2025 10:02, John Naylor wrote: >>> This is done -- thanks for the report, and for testing. >> >> It's good that this is done! But i still see the problem. > > Hi, my understanding was you previously tested with the revert. Did > you not actually test, or are you building differently for these > cases? My first test [1] was made at b7493e1 while the second [2] at ecb8226a after reverting in the 235328ee. The build process was the same in both cases. Both [1] and [2] contain pg_rightmost_one_pos64() call that lead to a valgrind error. Also i did this test very far back at e97b672c88 [3] and found no errors. With the best regards, -- Anton A. Melnikov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company [1] https://www.postgresql.org/message-id/a3a959f6-14b8-4819-ac04-eaf2aa2e868d%40postgrespro.ru [2] https://www.postgresql.org/message-id/f3aa2d45-3b28-41c5-9499-a1bc30e0f8ec%40postgrespro.ru [3] https://www.postgresql.org/message-id/4c739718-27d6-44fe-9113-56a251c13275%40postgrespro.ru