public inbox for [email protected]  
help / color / mirror / Atom feed
From: Erik Rijkers <[email protected]>
To: 曾文旌 <[email protected]>
Cc: Pavel Stehule <[email protected]>
Cc: Robert Haas <[email protected]>
Cc: Prabhat Sahu <[email protected]>
Cc: tushar <[email protected]>
Cc: Tomas Vondra <[email protected]>
Cc: Konstantin Knizhnik <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Cc: 蔡松露(子嘉) <[email protected]>
Cc: Cai, Le <[email protected]>
Cc: 萧少聪(铁庵) <[email protected]>
Subject: Re: [Proposal] Global temporary tables
Date: Tue, 07 Apr 2020 12:40:33 +0200
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <[email protected]>
	<CAFj8pRBo8YZ=bJESqf2fkxGL8Bq2Fs7=SjxisS7UhXHh6yPSfA@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<20200105200603.wrb4beacwb57hhpk@development>
	<[email protected]>
	<[email protected]>
	<20200109164829.mdl3z5xalmaqxs67@development>
	<[email protected]>
	<20200112015109.caab6qdr2ob6d5jv@development>
	<CA+TgmobRhPA1gVbMsj9YLA-sv0Ub8NpMrkWCKwRiD=bnjVND3Q@mail.gmail.com>
	<[email protected]>
	<CAFj8pRCnHvditiNKtGAByfzLjayOg0AZT-KXFvELvtfGJLRL8w@mail.gmail.com>
	<[email protected]>
	<CA+TgmobtnmTguphZ_7536yhzENzCSDPEkJnha-29a4Q7hAwEWg@mail.gmail.com>
	<[email protected]>
	<CAFj8pRBSFwhj+iccFF50WdrruAXbMsvqTMTfCVu9x2LPcvnd2w@mail.gmail.com>
	<CAFj8pRBNssuJoYH6d51-yqOfV2_nB+aK-Mj7maLPQH+O8cm-TA@mail.gmail.com>
	<[email protected]>
	<CAFj8pRCz52CbxnNmO=NK7cBA=9o=rdWVEBJRKOeVJ1FwzqzLRw@mail.gmail.com>
	<[email protected]>

On 2020-04-07 10:57, 曾文旌 wrote:

> [global_temporary_table_v24-pg13.patch ]

Hi,

With gcc 9.3.0 (debian stretch), I see some low-key protests during the 
build:

index.c: In function ‘index_drop’:
index.c:2051:8: warning: variable ‘rel_persistence’ set but not used 
[-Wunused-but-set-variable]
  2051 |  char  rel_persistence;
       |        ^~~~~~~~~~~~~~~
storage_gtt.c: In function ‘gtt_force_enable_index’:
storage_gtt.c:1252:6: warning: unused variable ‘indexOid’ 
[-Wunused-variable]
  1252 |  Oid indexOid = RelationGetRelid(index);
       |      ^~~~~~~~
cluster.c: In function ‘copy_table_data’:
cluster.c:780:2: warning: this ‘if’ clause does not guard... 
[-Wmisleading-indentation]
   780 |  if (RELATION_IS_GLOBAL_TEMP(OldHeap));
       |  ^~
cluster.c:781:3: note: ...this statement, but the latter is misleadingly 
indented as if it were guarded by the ‘if’
   781 |   is_gtt = true;
       |   ^~~~~~


Erik





view thread (492+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected], [email protected]
  Subject: Re: [Proposal] Global temporary tables
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox