Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pabYq-0004X1-Po for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Mar 2023 12:09:25 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pabYp-0004UI-M9 for pgsql-hackers@arkaria.postgresql.org; Fri, 10 Mar 2023 12:09:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pabVl-0007Q5-Fm for pgsql-hackers@lists.postgresql.org; Fri, 10 Mar 2023 12:06:13 +0000 Received: from mail.postgrespro.ru ([93.174.131.139]) by makus.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pabVf-00018O-9C for pgsql-hackers@lists.postgresql.org; Fri, 10 Mar 2023 12:06:12 +0000 Received: from [192.168.0.104] (unknown [62.217.188.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mail.postgrespro.ru (Postfix) with ESMTPSA id 6E25121CD9B0; Fri, 10 Mar 2023 15:06:04 +0300 (MSK) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=postgrespro.ru; s=mail; t=1678449964; bh=DOtLbpkiMb1Z499tNbUY8Tc6hG010e5wAQGd35/St8o=; h=Date:Subject:To:Cc:References:From:In-Reply-To; b=SArJ9Vex1jsaV/ZuwWn93fBp3JzzvJy2xZpOp8bksyxyOb0v6TdzO8n0cAqgzTGy6 X0RpbapSJEfVM8ipf74MjGh+21vZ6PHIVpgUeDy7GuRCT4XtNOrGnjGttsqFXSeU0j qkQVDGG5NseT/Y4GR9qUzjABebj/mvvBXvo/JDgc= Content-Type: multipart/alternative; boundary="------------k5qi06THO5ny9Topvb6JZ9Bc" Message-ID: <42678ca5-f3c6-db1b-e0c5-c63c3ce8997e@postgrespro.ru> Date: Fri, 10 Mar 2023 15:06:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: psql: Add role's membership options to the \du+ command Content-Language: en-US To: "David G. Johnston" Cc: David Zhang , "pgsql-hackers@lists.postgresql.org" References: <01620d6b-9efe-b199-b619-8450d865ec83@postgrespro.ru> <94ce7392-fa90-bc1c-4dc2-677161bbff58@postgrespro.ru> <20824093-d94f-e5d6-b611-8cec7fc6e95e@postgrespro.ru> From: Pavel Luzanov In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------k5qi06THO5ny9Topvb6JZ9Bc Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 08.03.2023 05:31, David G. Johnston wrote: > Moving the goal posts for this meta-command to >= 9.5 seems like it > should be done as a separate patch and thread.  The documentation > presently states we are targeting 9.2 and newer. I missed the comment at the beginning of the file about version 9.2. I will return the version check for rolbypassrls. > My suggestion for the docs is below. > +         > +        Shown within each row, in newline-separated format, are the > memberships granted to > +        the role.  The presentation includes both the name of the grantor > +        as well as the membership permissions (in an abbreviated format: > +        a for admin option, i > for inherit option, > +        s for set option.) The word > empty is printed in > +        the case that none of those permissions are granted. > +        See the linkend="sql-grant">GRANT command for their > meaning. > +         > +         > +        If the form \dg+ is used the comment > attached to the role is shown. >           Thanks. I will replace the description with this one. > I would suggest tweaking the test output to include regress_du_admin > and also to make regress_du_admin a CREATEROLE role with LOGIN. Ok. Thank you for review. I will definitely work on the new version, but unfortunately and with a high probability it will happen after March 20. -- Pavel Luzanov Postgres Professional:https://postgrespro.com --------------k5qi06THO5ny9Topvb6JZ9Bc Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 8bit On 08.03.2023 05:31, David G. Johnston wrote:
Moving the goal posts for this meta-command to >= 9.5 seems like it should be done as a separate patch and thread.  The documentation presently states we are targeting 9.2 and newer.

I missed the comment at the beginning of the file about version 9.2. I will return the version check for rolbypassrls.
My suggestion for the docs is below.
+        <para>
+        Shown within each row, in newline-separated format, are the memberships granted to
+        the role.  The presentation includes both the name of the grantor
+        as well as the membership permissions (in an abbreviated format:
+        <literal>a</literal> for admin option, <literal>i</literal> for inherit option,
+        <literal>s</literal> for set option.) The word <literal>empty</literal> is printed in
+        the case that none of those permissions are granted.
+        See the <link linkend="sql-grant"><command>GRANT</command></link> command for their meaning.
+        </para>
+        <para>
+        If the form <literal>\dg+</literal> is used the comment attached to the role is shown.
         </para>

Thanks. I will replace the description with this one.
I would suggest tweaking the test output to include regress_du_admin and also to make regress_du_admin a CREATEROLE role with LOGIN.

Ok.

Thank you for review. I will definitely work on the new version, but unfortunately and with a high probability it will happen after March 20.
-- 
Pavel Luzanov
Postgres Professional: https://postgrespro.com
--------------k5qi06THO5ny9Topvb6JZ9Bc--