From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
cc: Nikolay Shaplov <dhyan@nataraj.su>, pgsql-hackers@lists.postgresql.org,
        Michael Paquier <michael@paquier.xyz>
Subject: Re: [PATCH] check for ctags utility in make_ctags
In-reply-to: <ff4c82f8-6235-be2f-5b24-bca3e54ee811@2ndquadrant.com>
References: <2394207.ccz7JgCJsh@x200m> <3041301.tun4ao7M3a@x200m>
 <20190101022411.GC3243@paquier.xyz> <2372584.plvHIL0NPR@x200m>
 <ff4c82f8-6235-be2f-5b24-bca3e54ee811@2ndquadrant.com>
Comments: In-reply-to Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
	message dated "Wed, 02 Jan 2019 15:03:19 +0100"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4272.1546446946.1@sss.pgh.pa.us>
Date: Wed, 02 Jan 2019 11:35:46 -0500
Message-ID: <4273.1546446946@sss.pgh.pa.us>
Precedence: bulk

Peter Eisentraut <peter.eisentraut@2ndquadrant.com> writes:
> On 01/01/2019 17:44, Nikolay Shaplov wrote:
>> +if [ ! $(command -v ctags) ]
>> +then
>> +  echo "'ctags' utility is not found" 1>&2
>> +  echo "Please install 'ctags' to run make_ctags" 1>&2
>> +  exit 1
>> +fi

> This assumes that the ctags and etags programs are part of packages of
> the same name.  I don't think that is always the case.

In fact, that's demonstrably not so: on my RHEL6 and Fedora boxes,
/usr/bin/etags isn't owned by any package, because it's a symlink
managed by the "alternatives" system.  It points to /usr/bin/etags.emacs
which is owned by the emacs-common package.  So dropping the advice
about how to fix the problem seems like a good plan.

			regards, tom lane