Message-ID: <4297b4ee-5248-415f-ae12-abf2a23f4ab6@iki.fi>
Date: Tue, 7 Apr 2026 16:26:16 +0300
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: Better shared data structure management and resizable shared data
 structures
To: =?UTF-8?Q?Dagfinn_Ilmari_Manns=C3=A5ker?= <ilmari@ilmari.org>
Cc: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>,
 Robert Haas <robertmhaas@gmail.com>, Andres Freund <andres@anarazel.de>,
 pgsql-hackers <pgsql-hackers@postgresql.org>, chaturvedipalak1911@gmail.com
References: 
 <CAExHW5vM1bneLYfg0wGeAa=52UiJ3z4vKd3AJ72X8Fw6k3KKrg@mail.gmail.com>
 <8a6799be-bd42-49fb-8914-856c97bb1977@iki.fi>
 <CA+Tgmob8ot7qam7a650nx_4jyEoFLs8s_kPMc1+EB7-dr56=WA@mail.gmail.com>
 <cc3ff976-c303-45cd-9a8d-a90483170e37@iki.fi>
 <CA+TgmoauqYXm8iA3FGRAVKxYShUxWBiS_MSLmQpTrmO7wNHamw@mail.gmail.com>
 <113724ab-0028-493f-9605-6e8570f0939f@iki.fi>
 <CAExHW5uTNWOSxJDWQAUnS0tZawob2_J3dRAtc67NHNZ98X4_xA@mail.gmail.com>
 <CAExHW5t439y61YD9bc7d5wZWHp6J=M43Qu3eEZOBPguZML7o2A@mail.gmail.com>
 <CAExHW5v5FVZbsO9sLzztMZ11C3hgGStE=HkkV2bQkCyncess4w@mail.gmail.com>
 <b2451225-0a10-4ded-abef-4e9efbde7a8e@iki.fi>
 <CAExHW5tCC0T1ky=Jnq-AvMxa67Adaw7aQ4iQAO=BSdHcbSNBVg@mail.gmail.com>
 <791c3f18-f4de-4d84-ac6b-c7ccc074dd38@iki.fi>
 <CAExHW5tS7GncN90oJWOSzW_3F1EHL9xwe59L7Req3nUVgmObUw@mail.gmail.com>
 <9d919bd9-94dd-4bda-8ccf-ebced4178c53@iki.fi>
 <CAExHW5sYgt=XekOoAE-Tu_Dv8obWZCjCqAPT9vtN2D4m=M=drQ@mail.gmail.com>
 <470e7ebe-0971-49f6-8e46-9b8f6395f88b@iki.fi>
 <87y0iz2c1v.fsf@wibble.ilmari.org>
Content-Language: en-US
From: Heikki Linnakangas <hlinnaka@iki.fi>
In-Reply-To: <87y0iz2c1v.fsf@wibble.ilmari.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Archived-At: 
 <https://www.postgresql.org/message-id/4297b4ee-5248-415f-ae12-abf2a23f4ab6%40iki.fi>
Precedence: bulk

On 07/04/2026 15:24, Dagfinn Ilmari Mannsåker wrote:
> Heikki Linnakangas <hlinnaka@iki.fi> writes:
> 
>> Those are now committed, and here's a new version rebased over those
>> changes.
> 
> I noticed this bit during my habitual morning skim of new commits:
> 
>> diff --git a/src/backend/utils/misc/injection_point.c b/src/backend/utils/misc/injection_point.c
>> index c06b0e9b800..9981d6e212f 100644
>> --- a/src/backend/utils/misc/injection_point.c
>> +++ b/src/backend/utils/misc/injection_point.c
>> @@ -17,6 +17,7 @@
>>    */
>>   #include "postgres.h"
>>   
>> +#include "storage/subsystems.h"
>>   #include "utils/injection_point.h"
>>   
>>   #ifdef USE_INJECTION_POINTS
>> @@ -109,6 +110,11 @@ typedef struct InjectionPointCacheEntry
>>   
>>   static HTAB *InjectionPointCache = NULL;
>>   
>> +#ifdef USE_INJECTION_POINTS
>> +static void InjectionPointShmemRequest(void *arg);
>> +static void InjectionPointShmemInit(void *arg);
>> +#endif
>> +
> 
> This is already inside an `#ifdef USE_INJECTION_POINTS` guard (in fact
> visible at the end of the previous diff hunk), no need for another one.

Fixed, thanks. I also noticed that the #include "storage/subsystems.h" 
can be moved inside the #ifdef block; fixed that too.

- Heikki