X-Original-To: pgsql-hackers-postgresql.org@localhost.postgresql.org
Received: from localhost (unknown [200.46.204.144])
	by svr1.postgresql.org (Postfix) with ESMTP id 2A7D752915
	for <pgsql-hackers-postgresql.org@localhost.postgresql.org>;
	Sun,  3 Jul 2005 02:29:20 -0300 (ADT)
Received: from svr1.postgresql.org ([200.46.204.71])
	by localhost (av.hub.org [200.46.204.144]) (amavisd-new, port 10024)
	with ESMTP id 29325-03
	for <pgsql-hackers-postgresql.org@localhost.postgresql.org>;
	Sun,  3 Jul 2005 05:29:11 +0000 (GMT)
Received: from mailbox.samurai.com (mailbox.samurai.com [205.207.28.82])
	by svr1.postgresql.org (Postfix) with ESMTP id 49D3A52956
	for <pgsql-hackers@postgresql.org>;
	Sun,  3 Jul 2005 02:29:10 -0300 (ADT)
Received: from localhost (mailbox.samurai.com [205.207.28.82])
	by mailbox.samurai.com (Postfix) with ESMTP id 0F57718CDC8;
	Sun,  3 Jul 2005 01:29:11 -0400 (EDT)
Received: from mailbox.samurai.com ([205.207.28.82])
	by localhost (mailbox.samurai.com [205.207.28.82]) (amavisd-new,
	port 10024)
	with LMTP id 04989-01-3; Sun,  3 Jul 2005 01:29:09 -0400 (EDT)
Received: from [220.101.4.182] (r220-101-4-182.cpe.unwired.net.au
	[220.101.4.182])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mailbox.samurai.com (Postfix) with ESMTP id 684B718CF62;
	Sun,  3 Jul 2005 01:29:07 -0400 (EDT)
Message-ID: <42C7779E.30703@samurai.com>
Date: Sun, 03 Jul 2005 15:29:02 +1000
From: Neil Conway <neilc@samurai.com>
User-Agent: Mozilla Thunderbird 1.0.2 (Macintosh/20050317)
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Bruce Momjian <pgman@candle.pha.pa.us>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: bug in ALTER TABLE / TYPE
References: <200507022336.j62NaYn28549@candle.pha.pa.us>
In-Reply-To: <200507022336.j62NaYn28549@candle.pha.pa.us>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
X-Virus-Scanned: by amavisd-new at mailbox.samurai.com
X-Virus-Scanned: by amavisd-new at hub.org
X-Spam-Status: No, hits=0.006 tagged_above=0 required=5 tests=AWL
X-Spam-Level: 
X-Archive-Number: 200507/91
X-Sequence-Number: 70143

Bruce Momjian wrote:
> I realize this needs review, but I will put it the queue so we don't
> forget it.

The patch does not need review, as it doesn't even attempt to fix the 
problem. (I just wrote the patch while analyzing the problem to make the 
error condition more easily reproduceable). I haven't had a chance to 
take a look at how this ought to be fixed...

-Neil