Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glLNa-0000J9-OV for pgsql-hackers@arkaria.postgresql.org; Sun, 20 Jan 2019 22:15:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1glLNZ-0000ok-Cj for pgsql-hackers@arkaria.postgresql.org; Sun, 20 Jan 2019 22:15:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glLNY-0000oT-VA for pgsql-hackers@lists.postgresql.org; Sun, 20 Jan 2019 22:15:45 +0000 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1glLNU-0003rU-HJ for pgsql-hackers@postgresql.org; Sun, 20 Jan 2019 22:15:43 +0000 Received: by mail-wr1-x442.google.com with SMTP id l9so21103207wrt.13 for ; Sun, 20 Jan 2019 14:15:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=yIFx7iPD/BF5xInRXnun/OsP6ouT0H3g99U3jpLgSb8=; b=TwE3i951u9krchtqsOMefABP4vX9X+Ph0Ck8zjiqdI49MHuBq80eZ6fZdQHob7OM46 URU80ceQY2uYHuBjg1Mpo5SLEvbLAo8POmsZOTd0qqbybTPEiNbJ8jtw6J6g0MgquwdH uVjXFS7A7plySMR/c9HOBEfC3jPHoPNMoEs/uOr0ZARkiTk9tu6gdWsVf36wiP+VQF8M xGiOPhXSrPoID9Brh8Vjj9cPcpXAqrxa0AZx2UPDDj8cgQXQYh9DIw9zLTCsk9JDPr8b Vxm2hOs9E0pC6AWgBAYEUJe4q3oXTXrUnEM7oKpSvIyKgUkiu8sQs+ELbEnr7ey7oLVH RaCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=yIFx7iPD/BF5xInRXnun/OsP6ouT0H3g99U3jpLgSb8=; b=U7+nf04dnpaHtJrjrA5hRH8mrhxtNnrdlMNKwM3hLxMd4r4wcj1bQDX2JxpXtsUwpY 2LPQV+1VB5v4z0ywUS1SkLNwqdjpCvUfTnyhGRND6bp3q2IuKgsWDGDjDjYghV5bR63b XgmnXG56IMFqa4ZPMNaV3vgZu69LxuPUhCTpJHPqzqSAH0thBWpgIVFNdFdiqjJ+VHKZ riCUJfBmwbwgYNeLwD/q69PRiNKdKeDM8m4wcQYchrSUwIAXdC07IefdJBkMGoCLdt57 eCbC6118lRML1dH3QXMZxfdwRBKlVwdDQn4JFGIHizgHqRFKjBIFvCpc2pFa6fh2DyZX Se+g== X-Gm-Message-State: AJcUukfkwQ5cg9GfVUm3d+gtZQpWYbr3W5tdDzjTDt7rmZk/UDZtDYum q3y+ayzvEXaPqlWBvNuU6rEyZZjMtBJ4E1jIhwYg/RG3H0uJv05n1xgbXNRJlU2LV+zgYv7VzS7 VPJXKMrmh0pCJm550avCv2wgIR9i9wGU8PFeOMnbqxBvb20IapT9wMUV1anqZeMbphTqPTdJe2Z IcwnsntrspahM= X-Google-Smtp-Source: ALg8bN4mVjbcBNr0Z5iUAWkO8q4lJU8e19iFWex5x22IIZdSkF7hKHk3Fzu2A/JaTfCRPJMi55D1tg== X-Received: by 2002:adf:c7cc:: with SMTP id y12mr25976204wrg.52.1548022537760; Sun, 20 Jan 2019 14:15:37 -0800 (PST) Received: from [10.137.2.19] (ip-86-49-251-50.net.upcbroadband.cz. [86.49.251.50]) by smtp.gmail.com with ESMTPSA id z14sm64353042wrm.48.2019.01.20.14.15.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 20 Jan 2019 14:15:36 -0800 (PST) Subject: Re: [PROPOSAL] Shared Ispell dictionaries To: Arthur Zakirov Cc: Robert Haas , Tom Lane , Pavel Stehule , Andres Freund , pgsql-hackers References: <20180322105603.GA23544@zakirov.localdomain> <28250.1521924996@sss.pgh.pa.us> <25186.1521951490@sss.pgh.pa.us> <20180325205408.GA19457@arthur.localdomain> <27296.1522078068@sss.pgh.pa.us> <20180327121954.GA12726@zakirov.localdomain> <20180516113631.GA29544@zakirov.localdomain> <20180614084015.GA12451@zakirov.localdomain> <20181001092204.GA5071@zakirov.localdomain> <68aaaff6-0efe-c14b-7aee-fb110bb97f69@2ndquadrant.com> <337f7a55-58b8-4fcc-a933-5e7799fa6882@postgrespro.ru> From: Tomas Vondra Message-ID: <42b1ded6-fd44-5975-77e4-72ada1f134a2@2ndquadrant.com> Date: Sun, 20 Jan 2019 23:15:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk On 1/17/19 3:15 PM, Arthur Zakirov wrote: > I attached files of new version of the patch, I applied your tweaks. > >> XXX All dictionaries, but only when there's invalid dictionary? > > I've made a little optimization. I introduced hashvalue into > TSDictionaryCacheEntry. Now released only DSM of altered or dropped > dictionaries. > >>  > /* XXX not really a pointer, so the name is misleading */ >> >> I think we don't need DictPointerData struct anymore, because only >> ts_dict_shmem_release function needs it (see comments above) and we only >> need it to hash search. I'll move all fields of DictPointerData to >> TsearchDictKey struct. > > I was wrong, DictInitData also needs DictPointerData. I didn't remove > DictPointerData, I renamed it to DictEntryData. Hope that it is a more > appropriate name. > Thanks. I've reviewed v17 today and I haven't discovered any new issues so far. If everything goes fine and no one protests, I plan to get it committed over the next week or so. regards -- Tomas Vondra http://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services