From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: James Coleman <jtc331@gmail.com>,
        Tomas Vondra <tomas.vondra@2ndquadrant.com>,
        Michael Paquier <michael@paquier.xyz>,
        Rafia Sabih <rafia.pghackers@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
        Simon Riggs <simon@2ndquadrant.com>,
        Shaun Thomas <shaun.thomas@2ndquadrant.com>,
        Dmitry Dolgov <9erthalion6@gmail.com>,
        Alexander Korotkov <a.korotkov@postgrespro.ru>,
        PostgreSQL Developers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Incremental sort (was: PoC: Partial sort)
In-reply-to: <20200313194250.GA13008@alvherre.pgsql>
References: <20200313194250.GA13008@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Fri, 13 Mar 2020 16:42:50 -0300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4313.1584130939.1@sss.pgh.pa.us>
Date: Fri, 13 Mar 2020 16:22:19 -0400
Message-ID: <4314.1584130939@sss.pgh.pa.us>
Precedence: bulk

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> Also, I wonder if it would be better to modify our policies so that we
> update typedefs.list more frequently.  Some people include additions
> with their commits, but it's far from SOP.

Perhaps.  My own workflow includes pulling down a fresh typedefs.list
from the buildfarm (which is trivial to automate) and then adding any
typedefs invented by the patch I'm working on.  The latter part of it
makes it hard to see how the in-tree list would be very helpful; and
if we started expecting patches to include typedef updates, I'm afraid
we'd get lots of patch collisions in that file.

I don't have any big objection to updating the in-tree list more often,
but personally I wouldn't use it, unless we can find a better workflow.

			regards, tom lane