From: Ronan Dunklau <ronan.dunklau@aiven.io>
To: Stephen Frost <sfrost@snowman.net>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Provide a pg_truncate_freespacemap function
Date: Thu, 07 Mar 2024 08:59:02 +0100
Message-ID: <4331161.ejJDZkT8p0@aivenlaptop>
In-Reply-To: <ZejD7P+i2ZPDw8O/@tamriel.snowman.net>
References: 
 <5446938.Sb9uPGUboI@aivenlaptop> <ZejD7P+i2ZPDw8O/@tamriel.snowman.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="nextPart2183423.Mh6RI2rZIc"
Content-Transfer-Encoding: 7Bit
Archived-At: 
 <https://www.postgresql.org/message-id/4331161.ejJDZkT8p0%40aivenlaptop>
Precedence: bulk

This is a multi-part message in MIME format.

--nextPart2183423.Mh6RI2rZIc
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset="iso-8859-1"

Le mercredi 6 mars 2024, 20:28:44 CET Stephen Frost a =E9crit :
> I agree that this would generally be a useful thing to have.

Thanks !

>=20
> > Does that seem correct ?
>=20
> Definitely needs to have a 'REVOKE ALL ON FUNCTION' at the end of the
> upgrade script, similar to what you'll find at the bottom of
> pg_visibility--1.1.sql in the tree today, otherwise anyone could run it.
>=20
> Beyond that, I'd suggest a function-level comment above the definition
> of the function itself (which is where we tend to put those- not at the
> point where we declare the function).

Thank you for the review. Here is an updated patch for both of those.


Best regards,

=2D-
Ronan
--nextPart2183423.Mh6RI2rZIc
Content-Disposition: attachment;
 filename="0002-Provide-a-pg_truncate_freespacemap-function.patch"
Content-Transfer-Encoding: 7Bit
Content-Type: text/x-patch; charset="x-UTF_8J";
 name="0002-Provide-a-pg_truncate_freespacemap-function.patch"