Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ph8FS-00042V-Gq
	for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Mar 2023 12:16:22 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ph8FR-00067W-EZ
	for pgsql-hackers@arkaria.postgresql.org; Tue, 28 Mar 2023 12:16:21 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <torikoshia@oss.nttdata.com>)
	id 1ph8FR-00067N-5D
	for pgsql-hackers@lists.postgresql.org; Tue, 28 Mar 2023 12:16:21 +0000
Received: from oss.nttdata.com ([49.212.34.109])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <torikoshia@oss.nttdata.com>)
	id 1ph8FO-0005ID-Co
	for pgsql-hackers@postgresql.org; Tue, 28 Mar 2023 12:16:20 +0000
Received: from oss.nttdata.com (localhost [127.0.0.1])
	by oss.nttdata.com (Postfix) with ESMTPA id 4B22460651;
	Tue, 28 Mar 2023 21:16:13 +0900 (JST)
X-Virus-Status: Clean
X-Virus-Scanned: clamav-milter 0.103.8 at oss.nttdata.com
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII;
 format=flowed
Content-Transfer-Encoding: 7bit
Date: Tue, 28 Mar 2023 21:16:13 +0900
From: torikoshia <torikoshia@oss.nttdata.com>
To: Damir Belyalov <dam.bel07@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, tgl@sss.pgh.pa.us, Daniel Gustafsson
 <daniel@yesql.se>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, Danil
 Anisimow <anisimow.d@gmail.com>, Nikita Malakhov <HukuToc@gmail.com>,
 a.lepikhov@postgrespro.ru
Subject: Re: POC PATCH: copy from ... exceptions to: (was Re: VLDB Features)
In-Reply-To: <CALH1LguOY-VvJBWvjpLR2W3t0Z2p=LGSK5tzLrKwtzZ2UsqwGg@mail.gmail.com>
References: <483E1B59-4A80-450B-8685-7CC12762FD5A@anarazel.de>
 <2592557.1675663234@sss.pgh.pa.us>
 <39143e83571d59dfc04c75707fa0ea5a@oss.nttdata.com>
 <CALH1LgvQ5eRMi3zO7RSmod4ucru=9ekASpReahR7zDcCabANZw@mail.gmail.com>
 <0DE0602F-CC12-40ED-B259-3AB91FB02C3B@yesql.se>
 <8ad8492ff9fae3481d87c7aab4e0aed0@oss.nttdata.com>
 <CALH1LguAEsoTYJTCsXNB-7z2Hu9UGEpsXA4kj0FOTmoP=6Wp3Q@mail.gmail.com>
 <F2BEB24D-A6AB-4BB1-AC75-9A060E5338E0@yesql.se>
 <9a94e684d6528dff74de5959e97032f3@oss.nttdata.com>
 <8e5c596e47435e3b37b7a751ebcd9569@oss.nttdata.com>
 <20230322175000.qbdctk7bnmifh5an@awork3.anarazel.de>
 <16e09747fcfbb21c30e4c1009c416aa4@oss.nttdata.com>
 <19551e8c2717c24689913083f841ddb5@oss.nttdata.com>
 <CALH1LguOY-VvJBWvjpLR2W3t0Z2p=LGSK5tzLrKwtzZ2UsqwGg@mail.gmail.com>
User-Agent: Roundcube Webmail/1.4.11
Message-ID: <43399b33fe573f0548410893f41f84b6@oss.nttdata.com>
X-Sender: torikoshia@oss.nttdata.com
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: <https://www.postgresql.org/message-id/43399b33fe573f0548410893f41f84b6%40oss.nttdata.com>
Precedence: bulk

On 2023-03-27 23:28, Damir Belyalov wrote:
> Hi!
> 
> I made the specified changes and my patch turned out the same as
> yours. The performance measurements were the same too.

Thanks for your review and measurements.

> The only thing left to do is how not to add IGNORE_DATATYPE_ERRORS as
> a keyword. See how this is done for parameters such as FORCE_NOT_NULL,
> FORCE_NULL, FORCE_QUOTE. They are not in kwlist.h and are not as
> keywords in gram.y.

I might misunderstand something, but I believe the v5 patch uses 
copy_generic_opt_list and it does not add IGNORE_DATATYPE_ERRORS as a 
keyword.
It modifies neither kwlist.h nor gram.y.

-- 
Regards,

--
Atsushi Torikoshi
NTT DATA CORPORATION