public inbox for [email protected]  
help / color / mirror / Atom feed
From: Fujii Masao <[email protected]>
To: Kirill Reshke <[email protected]>
To: jian he <[email protected]>
Cc: PostgreSQL-development <[email protected]>
Subject: Re: tab complete for COPY populated materialized view TO
Date: Wed, 9 Apr 2025 18:45:08 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <CALdSSPi_Aw2EZwQiKDE7MjW9m6yDPH++xGTOrWu3o=RWyq5qHQ@mail.gmail.com>
References: <CACJufxFxnSkikp+GormAGHcMTX1YH2HRXW1+3dJM9w7yY9hdsg@mail.gmail.com>
	<CALdSSPi_Aw2EZwQiKDE7MjW9m6yDPH++xGTOrWu3o=RWyq5qHQ@mail.gmail.com>



On 2025/04/09 18:25, Kirill Reshke wrote:
> On Wed, 9 Apr 2025 at 13:23, jian he <[email protected]> wrote:
>>
>> hi.
>>
>> we allow the "COPY table TO" command to copy rows from materialized
>> views in [1].
>> The attached patch is to add a tab complete for it.
>>
>> [1] https://git.postgresql.org/cgit/postgresql.git/commit/?id=534874fac0b34535c9a5ab9257d6574f78423578
> 
> Hi!
> Patch works good for me, but I noticed that psql COPY <tab> suggests
> partitioned relation both with and without this patch. Maybe that's
> not a big problem, if [0] will be pushed.

Is the partitioned table currently tab-completed for the COPY FROM case?

If we aim to support tab-completion for all valid targets of both COPY TO
and COPY FROM, shouldn't foreign tables also be included? And what about
views with INSTEAD OF INSERT triggers - though maybe that's overkill?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION







view thread (8+ messages)  latest in thread

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected]
  Subject: Re: tab complete for COPY populated materialized view TO
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox