Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.92) (envelope-from ) id 1jDym8-0002HG-IR for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Mar 2020 23:04:00 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1jDym7-00020O-BU for pgsql-hackers@arkaria.postgresql.org; Mon, 16 Mar 2020 23:03:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1jDym6-00020B-V6 for pgsql-hackers@lists.postgresql.org; Mon, 16 Mar 2020 23:03:59 +0000 Received: from mail-pl1-x644.google.com ([2607:f8b0:4864:20::644]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1jDym4-0004xM-7k for pgsql-hackers@lists.postgresql.org; Mon, 16 Mar 2020 23:03:57 +0000 Received: by mail-pl1-x644.google.com with SMTP id t3so8686863plz.9 for ; Mon, 16 Mar 2020 16:03:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=enterprisedb-com.20150623.gappssmtp.com; s=20150623; h=from:mime-version:subject:message-id:date:to; bh=QxcrhHzgPgA1wRYWyAoFD7Pv7aWBnp2qDBKyU02RcwE=; b=t5Ll3rOOvZYNKqFkEWLNiFI4jXrMzHuwRlTFLLKJ1igUVsF9SesIZLXvYPpDkEHRZ2 nQF39/2pSxChZjdOojdfikbofle6RgfVzQ08r/6BeHzR5M6Q24+sHtz2D7iKXi3Y+AkD 28MDdW7+TSHnxTzf9L73Nhmi8wh0cNo/fa+pu8hAXQqu8POI+XfHXn1H6P3Gf9+7w2zG +GhbdvSPqOqTWXlhiiiuRFKwYUmFYKeOrBhLZJ5mhWz4iPJO9OWQWhVOpQFQPUDxxAcc vFsIS3uJ+HEnO+ffqw1+g+ItqbKHzO575xSa8DVcVGyG5rGNIHlTyqNMTeRjrIdGHSps l9Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:subject:message-id:date:to; bh=QxcrhHzgPgA1wRYWyAoFD7Pv7aWBnp2qDBKyU02RcwE=; b=gSwP+KbcPkB60IZ7M2c2vV1nG/5124pwjU2/4eNnE/Ch16mW9XVk0jKDhx6TzdxLsD n0fNimqnbSs2swszyi74vhRyr3eZHb4jNQAy/DfGrZzPXo82U/9dO9kqJlnK/x33Z0Qe VBP9ey5dQqOAEyQWp5AXGue5L+xfBckYgLSUSXfewsA3xrqHIOudNlZzJho1LiYJZ162 gWOms0/FrtH2l1D6sndqa4uzyy7V1GcWyEW6ZyppDflkoRYAvQR7ixpxSbWcoExpQTRH WrxeRx1y6NjZs0ln/OWO6MIrQ/fKms/UIn/5okLt8x9kq0f5uq1eSA8SlpCn2ecsKFW1 mxHQ== X-Gm-Message-State: ANhLgQ2YNsSiqMgSsyOGoXMTpHfftKzb+ThUGUv0ML52K/x0321BJXrU 0zo2vaugh2sMMwqfK7B9S41FrrZWxvY9Hw3mIeXG9/p8SAh5F5kJo24C5CpR4X3SmaqRRTrzC1U stTesKnyxxXWpBhK/FW6jZkezyx1GkNxlQw5ET0Efo0DXzyXIDXexAssmCUA4d7eBAJu4eAGt7x AOGgwiBvwsb79WF5/lj0IFmLNZUJJKtEwrABwi9b1RNBE5QyEMfx5/Kcu/AWyJMnCOizO/eZtOR ffhUM4Si6Vw1LGPqdFLeAp5h5PduKw0xUD1SH5GN34= X-Google-Smtp-Source: ADFU+vumssoDAwdSTs71En7CCKDzGYvRhTsCiu9rEJNnSGhUFS7LxCHGoRMUpxSK2WKTQUER9mDWqw== X-Received: by 2002:a17:902:ff09:: with SMTP id f9mr1386083plj.95.1584399833928; Mon, 16 Mar 2020 16:03:53 -0700 (PDT) Received: from [192.168.0.29] (24-113-193-150.wavecable.com. [24.113.193.150]) by smtp.gmail.com with ESMTPSA id g2sm522999pgi.20.2020.03.16.16.03.52 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 16 Mar 2020 16:03:52 -0700 (PDT) From: Mark Dilger Content-Type: multipart/mixed; boundary="Apple-Mail=_7F096538-E313-4A0D-86C0-F6C6F61278C0" Mime-Version: 1.0 (Mac OS X Mail 13.0 \(3608.60.0.2.5\)) Subject: Adding missing object access hook invocations Message-Id: <435CD295-F409-44E0-91EC-DF32C7AFCD76@enterprisedb.com> Date: Mon, 16 Mar 2020 16:03:51 -0700 To: "pgsql-hackers@postgresql.org" X-Mailer: Apple Mail (2.3608.60.0.2.5) X-CLOUD-SEC-AV-Info: edb,google_mail,monitor X-CLOUD-SEC-AV-Sent: true X-Gm-Spam: 0 X-Gm-Phishy: 0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk --Apple-Mail=_7F096538-E313-4A0D-86C0-F6C6F61278C0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii Hackers, While working on object access hooks, I noticed several locations where = I would expect the hook to be invoked, but no actual invocation. I = think this just barely qualifies as a bug. It's debatable because = whether it is a bug depends on the user's expectations and whether not = invoking the hook in these cases is defensible. Does anybody have any = recollection of an intentional choice not to invoke in these locations? Patch attached. --Apple-Mail=_7F096538-E313-4A0D-86C0-F6C6F61278C0 Content-Disposition: attachment; filename=v1-0001-Adding-missing-Object-Access-hook-invocations.patch Content-Type: application/octet-stream; x-unix-mode=0644; name="v1-0001-Adding-missing-Object-Access-hook-invocations.patch" Content-Transfer-Encoding: quoted-printable =46rom=202759f8deefc89e40eb6a299540961aa5e8fd6b61=20Mon=20Sep=2017=20= 00:00:00=202001=0AFrom:=20Mark=20Dilger=20=0A= Date:=20Mon,=2016=20Mar=202020=2008:53:32=20-0700=0ASubject:=20[PATCH=20= v1]=20Adding=20missing=20Object=20Access=20hook=20invocations.=0A=0A= There=20appears=20to=20be=20no=20reason=20for=20skipping=20the=20= invocation=20of=20the=0Aobject=20access=20hook=20infrastructure=20for=20= the=20following=20commands,=20yet=0Athey=20were=20lacking=20the=20= InvokeObject{PostCreate,PostAlter,Drop}Hook=0Acalls=20that=20would=20be=20= expected:=0A=0AALTER=20RULE=0AALTER=20USER=20MAPPING=0ACREATE=20ACCESS=20= METHOD=0ACREATE=20STATISTICS=0ADROP=20STATISTICS=0ADROP=20ACCESS=20= METHOD=0A=0AThere=20doesn't=20seem=20to=20be=20any=20good=20regression=20= test=20coverage=20for=0Awhen=20and=20how=20the=20object_access_hook=20is=20= invoked,=20so=20no=20additional=0Acoverage=20is=20included=20here,=20= either.=20=20Adding=20regression=20test=0Acoverage=20seems=20like=20= another=20patch=20to=20be=20submitted=20separately.=0A---=0A=20= src/backend/commands/amcmds.c=20=20=20=20=20=20=20|=205=20+++++=0A=20= src/backend/commands/foreigncmds.c=20=20|=203=20+++=0A=20= src/backend/commands/statscmds.c=20=20=20=20|=204=20++++=0A=20= src/backend/rewrite/rewriteDefine.c=20|=202=20++=0A=204=20files=20= changed,=2014=20insertions(+)=0A=0Adiff=20--git=20= a/src/backend/commands/amcmds.c=20b/src/backend/commands/amcmds.c=0A= index=207546378bbb..1ecad090ee=20100644=0A---=20= a/src/backend/commands/amcmds.c=0A+++=20b/src/backend/commands/amcmds.c=0A= @@=20-18,6=20+18,7=20@@=0A=20#include=20"catalog/catalog.h"=0A=20= #include=20"catalog/dependency.h"=0A=20#include=20"catalog/indexing.h"=0A= +#include=20"catalog/objectaccess.h"=0A=20#include=20"catalog/pg_am.h"=0A= =20#include=20"catalog/pg_proc.h"=0A=20#include=20"catalog/pg_type.h"=0A= @@=20-107,6=20+108,8=20@@=20CreateAccessMethod(CreateAmStmt=20*stmt)=0A=20= =0A=20=09recordDependencyOnCurrentExtension(&myself,=20false);=0A=20=0A+=09= InvokeObjectPostCreateHook(AccessMethodRelationId,=20amoid,=200);=0A+=0A=20= =09table_close(rel,=20RowExclusiveLock);=0A=20=0A=20=09return=20myself;=0A= @@=20-134,6=20+137,8=20@@=20RemoveAccessMethodById(Oid=20amOid)=0A=20=0A=20= =09CatalogTupleDelete(relation,=20&tup->t_self);=0A=20=0A+=09= InvokeObjectDropHook(AccessMethodRelationId,=20amOid,=200);=0A+=0A=20=09= ReleaseSysCache(tup);=0A=20=0A=20=09table_close(relation,=20= RowExclusiveLock);=0Adiff=20--git=20a/src/backend/commands/foreigncmds.c=20= b/src/backend/commands/foreigncmds.c=0Aindex=20f197869752..a399ab4de9=20= 100644=0A---=20a/src/backend/commands/foreigncmds.c=0A+++=20= b/src/backend/commands/foreigncmds.c=0A@@=20-1343,6=20+1343,9=20@@=20= AlterUserMapping(AlterUserMappingStmt=20*stmt)=0A=20=0A=20=09= CatalogTupleUpdate(rel,=20&tp->t_self,=20tp);=0A=20=0A+=09= InvokeObjectPostAlterHook(UserMappingRelationId,=0A+=09=09=09=09=09=09=09= =20=20umId,=200);=0A+=0A=20=09ObjectAddressSet(address,=20= UserMappingRelationId,=20umId);=0A=20=0A=20=09heap_freetuple(tp);=0Adiff=20= --git=20a/src/backend/commands/statscmds.c=20= b/src/backend/commands/statscmds.c=0Aindex=20988cdba6f5..08d0da1109=20= 100644=0A---=20a/src/backend/commands/statscmds.c=0A+++=20= b/src/backend/commands/statscmds.c=0A@@=20-374,6=20+374,8=20@@=20= CreateStatistics(CreateStatsStmt=20*stmt)=0A=20=0A=20=09= relation_close(datarel,=20RowExclusiveLock);=0A=20=0A+=09= InvokeObjectPostCreateHook(StatisticExtRelationId,=20statoid,=200);=0A+=0A= =20=09/*=0A=20=09=20*=20Invalidate=20relcache=20so=20that=20others=20see=20= the=20new=20statistics=20object.=0A=20=09=20*/=0A@@=20-568,6=20+570,8=20= @@=20RemoveStatisticsById(Oid=20statsOid)=0A=20=0A=20=09= CatalogTupleDelete(relation,=20&tup->t_self);=0A=20=0A+=09= InvokeObjectDropHook(StatisticExtRelationId,=20statsOid,=200);=0A+=0A=20=09= ReleaseSysCache(tup);=0A=20=0A=20=09table_close(relation,=20= RowExclusiveLock);=0Adiff=20--git=20= a/src/backend/rewrite/rewriteDefine.c=20= b/src/backend/rewrite/rewriteDefine.c=0Aindex=20afc78b3316..9989df1107=20= 100644=0A---=20a/src/backend/rewrite/rewriteDefine.c=0A+++=20= b/src/backend/rewrite/rewriteDefine.c=0A@@=20-1003,6=20+1003,8=20@@=20= RenameRewriteRule(RangeVar=20*relation,=20const=20char=20*oldName,=0A=20=0A= =20=09CatalogTupleUpdate(pg_rewrite_desc,=20&ruletup->t_self,=20= ruletup);=0A=20=0A+=09InvokeObjectPostAlterHook(RewriteRelationId,=20= ruleOid,=200);=0A+=0A=20=09heap_freetuple(ruletup);=0A=20=09= table_close(pg_rewrite_desc,=20RowExclusiveLock);=0A=20=0A--=20=0A2.21.1=20= (Apple=20Git-122.3)=0A=0A= --Apple-Mail=_7F096538-E313-4A0D-86C0-F6C6F61278C0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 =E2=80=94 Mark Dilger EnterpriseDB: http://www.enterprisedb.com The Enterprise PostgreSQL Company --Apple-Mail=_7F096538-E313-4A0D-86C0-F6C6F61278C0--