public inbox for [email protected]  

help / color / mirror / Atom feed
From: Fujii Masao <[email protected]>
To: Daniel Gustafsson <[email protected]>
Cc: Rahila Syed <[email protected]>
Cc: Andres Freund <[email protected]>
Cc: PostgreSQL Hackers <[email protected]>
Subject: Re: Enhancing Memory Context Statistics Reporting
Date: Wed, 9 Apr 2025 08:28:09 +0900
Message-ID: <[email protected]> (raw)
In-Reply-To: <[email protected]>
References: <CAExHW5skNvp265od6XPs0O-RL3cwtgHW3N87Ob0+nByZ=_HzAA@mail.gmail.com>
	<CAH2L28sMyRh_ZomRxkx_RdaQoLcyGAwKCr1TSmrVudbbR_Q1eQ@mail.gmail.com>
	<[email protected]>
	<CAH2L28v9EU4dxKUpvMt_CFAzG72CYusPWxADsgT=cwFJP-fP0A@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<CAH2L28s+s4JJdPz2RkALzOvXpxXUcmm=fvg-Y6M82g9Cp=bB-w@mail.gmail.com>
	<[email protected]>
	<5bxhxniyvjyfldi7yjxcnxkl3i2ghci2grjyeclrbkfqnyhowk@dfkqzbvtbpml>
	<[email protected]>
	<tesneyk3z2dtrjgwlmkw2wbr7e3olwkowlpke6kl463hfhxedb@fyyqsnwjcp4l>
	<CAH2L28tp8RMa0CrCgdCJw20vFzeGQMuHkXAoPgYC5JZuXY8_+g@mail.gmail.com>
	<[email protected]>
	<[email protected]>
	<[email protected]>
	<[email protected]>



On 2025/04/09 6:27, Daniel Gustafsson wrote:
>> On 8 Apr 2025, at 18:41, Fujii Masao <[email protected]> wrote:
> 
>> I noticed that the third argument of pg_get_process_memory_contexts() is named
>> "retries" in pg_proc.dat, while the documentation refers to it as "timeout".
> 
> I've committed this patch as it was obviously correct, thanks!

Thanks a lot!

Since pg_proc.dat was modified, do we need to bump the catalog version?


>> Also, as I mentioned earlier, I encountered an issue when calling
>> pg_get_process_memory_contexts() on the PID of a backend that had just
>> encountered an error but hadn't finished rolling back. It led to
>> the following situation:
> 
> I reconfirmed that the bugfix that Rahila shared in [0] fixes this issue (and
> will fix others like it, as it's not related to this patch in particular but is
> a bug in DSM attaching).  My plan is to take that for a more thorough review
> and test tomorrow and see how far it can be safely backpatched.  Thanks for
> bringing this up, sorry about it getting a bit lost among all the emails.

Appreciate your work on this!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION







view thread (5+ messages)

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: [email protected]
  Cc: [email protected], [email protected], [email protected], [email protected]
  Subject: Re: Enhancing Memory Context Statistics Reporting
  In-Reply-To: <[email protected]>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox