Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pAgQd-00073L-Bc
	for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Dec 2022 00:05:47 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1pAgQc-00049P-0v
	for pgsql-hackers@arkaria.postgresql.org; Thu, 29 Dec 2022 00:05:46 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pAgQb-00049G-OS
	for pgsql-hackers@lists.postgresql.org; Thu, 29 Dec 2022 00:05:45 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1pAgQZ-0004Ol-Ex
	for pgsql-hackers@postgresql.org; Thu, 29 Dec 2022 00:05:44 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 2BT05Zo4438140;
	Wed, 28 Dec 2022 19:05:35 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        pgsql-hackers@postgresql.org, David Rowley <dgrowleyml@gmail.com>,
        Dagfinn Ilmari =?utf-8?Q?Manns=C3=A5ker?= <ilmari@ilmari.org>
Subject: Re: perl 5.36, C99,
 -Wdeclaration-after-statement -Wshadow=compatible-local
In-reply-to: <20221229000223.2pdwxexfrgoximul@awork3.anarazel.de>
References: <20221101180158.l4zg6ljah5ow2vvo@awork3.anarazel.de>
 <e5e13d55-8c8b-30a6-0b13-0304a3e562dd@enterprisedb.com>
 <20221102234346.zcupk5mqysavci4t@awork3.anarazel.de>
 <1881935.1667433465@sss.pgh.pa.us>
 <20221103000334.sbh5jqw37i3y7pc3@awork3.anarazel.de>
 <20221228182455.hfdwd22zztvkojy2@awork3.anarazel.de>
 <356473.1672253007@sss.pgh.pa.us>
 <20221229000223.2pdwxexfrgoximul@awork3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Wed, 28 Dec 2022 16:02:23 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <438138.1672272335.1@sss.pgh.pa.us>
Date: Wed, 28 Dec 2022 19:05:35 -0500
Message-ID: <438139.1672272335@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/438139.1672272335%40sss.pgh.pa.us>
Precedence: bulk

Andres Freund <andres@anarazel.de> writes:
> On 2022-12-28 13:43:27 -0500, Tom Lane wrote:
>> Hmm ... I guess the buildfarm would tell us whether that detection works
>> correctly on platforms where it matters.  Let's keep it simple if we
>> can.

> Quick clarification question: Are you suggesting to use #ifdef __GNUC__, or
> that it suffices to use -Werror=unknown-pragmas without a separate configure
> check?

I'd try -Werror=unknown-pragmas, and then go to the #ifdef if that
doesn't seem to work well.

			regards, tom lane