Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX154-0006q2-7w for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Mar 2022 13:31:18 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nX152-0002rI-7n for pgsql-hackers@arkaria.postgresql.org; Wed, 23 Mar 2022 13:31:16 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX151-0002o1-Ud for pgsql-hackers@lists.postgresql.org; Wed, 23 Mar 2022 13:31:15 +0000 Received: from relay10.mail.gandi.net ([2001:4b98:dc4:8::230]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nX14w-0001oP-Vs for pgsql-hackers@lists.postgresql.org; Wed, 23 Mar 2022 13:31:14 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 7253A240014 for ; Wed, 23 Mar 2022 13:31:05 +0000 (UTC) Content-Type: multipart/mixed; boundary="------------UGoZqEWU0EukrP6acNz44lAK" Message-ID: <43bcaaab-077e-cebe-35be-3cd7f2633449@dunslane.net> Date: Wed, 23 Mar 2022 09:31:04 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 From: Andrew Dunstan Subject: clean up test_rls_hooks module To: PostgreSQL Hackers Content-Language: en-US List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------UGoZqEWU0EukrP6acNz44lAK Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Over at [1] Mark Dilger got led astray because he used src/test/modules/test_rls_hooks as a template for his new test module. It looks like that module was created with some over eager copying of another test module, but it has a couple of things wrong with it. . it isn't an extension, so the Makefile shouldn't have an EXTENSION entry, and there shouldn't be a .control file . it doesn't need to be preloaded so there is no requirement for a special config, nor for corresponding REGRESS_OPTS and NO_INSTALLCHECK lines in the Makefile. Here's a patch to fix those things. cheers andrew [1] https://postgr.es/m/47F87A0E-C0E5-43A6-89F6-D403F2B45175@enterprisedb.com -- Andrew Dunstan EDB: https://www.enterprisedb.com --------------UGoZqEWU0EukrP6acNz44lAK Content-Type: text/x-patch; charset=UTF-8; name="0001-fix-test_rls_hooks.patch" Content-Disposition: attachment; filename="0001-fix-test_rls_hooks.patch" Content-Transfer-Encoding: base64 RnJvbSAyMWYzMTZkMjk4ODFjMzI5NGY4ZDBiMWJjMmYwZGRlOGVlYzM4YzJkIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgRHVuc3RhbiA8YW5kcmV3QGR1bnNsYW5l Lm5ldD4KRGF0ZTogV2VkLCAyMyBNYXIgMjAyMiAwODo0OTowNyAtMDQwMApTdWJqZWN0OiBb UEFUQ0hdIGZpeCB0ZXN0X3Jsc19ob29rcwoKLS0tCiBzcmMvdGVzdC9tb2R1bGVzL3Rlc3Rf cmxzX2hvb2tzL01ha2VmaWxlICAgICAgICAgICAgIHwgMTIgKystLS0tLS0tLS0tCiBzcmMv dGVzdC9tb2R1bGVzL3Rlc3RfcmxzX2hvb2tzL3Jsc19ob29rcy5jb25mICAgICAgIHwgIDEg LQogLi4uL21vZHVsZXMvdGVzdF9ybHNfaG9va3MvdGVzdF9ybHNfaG9va3MuY29udHJvbCAg ICB8ICA0IC0tLS0KIDMgZmlsZXMgY2hhbmdlZCwgMiBpbnNlcnRpb25zKCspLCAxNSBkZWxl dGlvbnMoLSkKIGRlbGV0ZSBtb2RlIDEwMDY0NCBzcmMvdGVzdC9tb2R1bGVzL3Rlc3Rfcmxz X2hvb2tzL3Jsc19ob29rcy5jb25mCiBkZWxldGUgbW9kZSAxMDA2NDQgc3JjL3Rlc3QvbW9k dWxlcy90ZXN0X3Jsc19ob29rcy90ZXN0X3Jsc19ob29rcy5jb250cm9sCgpkaWZmIC0tZ2l0 IGEvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X3Jsc19ob29rcy9NYWtlZmlsZSBiL3NyYy90ZXN0 L21vZHVsZXMvdGVzdF9ybHNfaG9va3MvTWFrZWZpbGUKaW5kZXggYTRmN2Q4NTVjMC4uNTE5 ZWI5NTEzZCAxMDA2NDQKLS0tIGEvc3JjL3Rlc3QvbW9kdWxlcy90ZXN0X3Jsc19ob29rcy9N YWtlZmlsZQorKysgYi9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfcmxzX2hvb2tzL01ha2VmaWxl CkBAIC0xLDE5ICsxLDExIEBACiAjIHNyYy90ZXN0L21vZHVsZXMvdGVzdF9ybHNfaG9va3Mv TWFrZWZpbGUKIAogTU9EVUxFX2JpZyA9IHRlc3RfcmxzX2hvb2tzCi1PQkpTID0gXAotCSQo V0lOMzJSRVMpIFwKLQl0ZXN0X3Jsc19ob29rcy5vCi1QR0ZJTEVERVNDID0gInRlc3Rfcmxz X2hvb2tzIC0gZXhhbXBsZSB1c2Ugb2YgUkxTIGhvb2tzIgorT0JKUyA9IHRlc3RfcmxzX2hv b2tzLm8gJChXSU4zMlJFUykKIAotRVhURU5TSU9OID0gdGVzdF9ybHNfaG9va3MKLSMgREFU QSA9IHRlc3RfcmxzX2hvb2tzLS0xLjAuc3FsCitQR0ZJTEVERVNDID0gInRlc3RfcmxzX2hv b2tzIC0gZXhhbXBsZSB1c2Ugb2YgUkxTIGhvb2tzIgogCiBSRUdSRVNTID0gdGVzdF9ybHNf aG9va3MKLVJFR1JFU1NfT1BUUyA9IC0tdGVtcC1jb25maWc9JCh0b3Bfc3JjZGlyKS9zcmMv dGVzdC9tb2R1bGVzL3Rlc3RfcmxzX2hvb2tzL3Jsc19ob29rcy5jb25mCi0jIERpc2FibGVk IGJlY2F1c2UgdGhlc2UgdGVzdHMgcmVxdWlyZSAic2hhcmVkX3ByZWxvYWRfbGlicmFyaWVz PXRlc3RfcmxzX2hvb2tzIiwKLSMgd2hpY2ggdHlwaWNhbCBpbnN0YWxsY2hlY2sgdXNlcnMg ZG8gbm90IGhhdmUgKGUuZy4gYnVpbGRmYXJtIGNsaWVudHMpLgotTk9fSU5TVEFMTENIRUNL ID0gMQogCiBpZmRlZiBVU0VfUEdYUwogUEdfQ09ORklHID0gcGdfY29uZmlnCmRpZmYgLS1n aXQgYS9zcmMvdGVzdC9tb2R1bGVzL3Rlc3RfcmxzX2hvb2tzL3Jsc19ob29rcy5jb25mIGIv c3JjL3Rlc3QvbW9kdWxlcy90ZXN0X3Jsc19ob29rcy9ybHNfaG9va3MuY29uZgpkZWxldGVk IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggYTUyMmMwZTU1MC4uMDAwMDAwMDAwMAotLS0gYS9z cmMvdGVzdC9tb2R1bGVzL3Rlc3RfcmxzX2hvb2tzL3Jsc19ob29rcy5jb25mCisrKyAvZGV2 L251bGwKQEAgLTEgKzAsMCBAQAotc2hhcmVkX3ByZWxvYWRfbGlicmFyaWVzID0gdGVzdF9y bHNfaG9va3MKZGlmZiAtLWdpdCBhL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9ybHNfaG9va3Mv dGVzdF9ybHNfaG9va3MuY29udHJvbCBiL3NyYy90ZXN0L21vZHVsZXMvdGVzdF9ybHNfaG9v a3MvdGVzdF9ybHNfaG9va3MuY29udHJvbApkZWxldGVkIGZpbGUgbW9kZSAxMDA2NDQKaW5k ZXggOWY5ZjEzZjc2Yy4uMDAwMDAwMDAwMAotLS0gYS9zcmMvdGVzdC9tb2R1bGVzL3Rlc3Rf cmxzX2hvb2tzL3Rlc3RfcmxzX2hvb2tzLmNvbnRyb2wKKysrIC9kZXYvbnVsbApAQCAtMSw0 ICswLDAgQEAKLWNvbW1lbnQgPSAnVGVzdCBjb2RlIGZvciBSTFMgaG9va3MnCi1kZWZhdWx0 X3ZlcnNpb24gPSAnMS4wJwotbW9kdWxlX3BhdGhuYW1lID0gJyRsaWJkaXIvdGVzdF9ybHNf aG9va3MnCi1yZWxvY2F0YWJsZSA9IHRydWUKLS0gCjIuMjUuMQoK --------------UGoZqEWU0EukrP6acNz44lAK--