Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvHqJ-004LSB-1f for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Oct 2023 13:53:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1qvHqG-0083rC-QL for pgsql-hackers@arkaria.postgresql.org; Tue, 24 Oct 2023 13:53:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1qvHqG-0083r2-CR for pgsql-hackers@lists.postgresql.org; Tue, 24 Oct 2023 13:53:09 +0000 Received: from mail-qk1-x72d.google.com ([2607:f8b0:4864:20::72d]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1qvHqC-002Sw2-T2 for pgsql-hackers@postgresql.org; Tue, 24 Oct 2023 13:53:08 +0000 Received: by mail-qk1-x72d.google.com with SMTP id af79cd13be357-77063481352so440314185a.1 for ; Tue, 24 Oct 2023 06:53:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dunslane-net.20230601.gappssmtp.com; s=20230601; t=1698155583; x=1698760383; darn=postgresql.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=naXtXvFRtHWnfsqoUNnJq3FyOJUwZc/Fmo/cOD2xlVc=; b=IthM2DH+7ywKt8JRFJZiRyi+a1JAi09LX44hNIx41NnWIFyFPxIMTvnb8kSf1marWX Dz5x3ayqoqKoxjNacNGuETmKLMq/1hriZgeXEhyssS5xIW83Up6EMwDycqyomchT1rSR IYuO44mowGaPUHvJoKDXorJ97+Vq4ShENOYcIVoSPqHgN+GEqhySAmv87w5g6TeyuHc5 roINI9ETGJP6r9A9CWMgD8UJz5/si9INjtDNAhRoFNzrdxW2FmTiMvBHGReZD8OM/m6E u/rqGS7HjOxdqak43tqoTL3iQt4UYgNaqhelqHfgpsBsiky2jB3F+LYWihlqok5aWpci kmpQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698155583; x=1698760383; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=naXtXvFRtHWnfsqoUNnJq3FyOJUwZc/Fmo/cOD2xlVc=; b=REj+erfPhFGTktm+RaeelTmPNJpt0u1l0hBTybV7e7Fngc39uPAH8yTj654V8nLOPE zmV/6ij96jsf0YIkMhczRsWb6Y/RreYIC44d9mS/xVjPrrIZq71CZXvc8eyvC0iyIE8R 1RU7bsqAF0ER8578q/Ey7BpHel92SsI5m9tNgCDNvU93TazcZLSsQchkd9HtoDLSavhh AYotpnBNutr4AX6si8sT3iWcMMB2WZIw9MzWNuZ6Edbt+aplk/WAs9JsBSAWSTQrmk/X Y5dpGnaREu2LPfBDB9Kf/dYMmGk2iNshvdVZZ4QBlG+fEgTp45rSFg1CLM8+gREybRJT tD3g== X-Gm-Message-State: AOJu0YxSTpBUSpcXSVapXye53ORjQ1ceHPKoeFsi9xagsfEgvt9Aww7n dhWB8/u5e2R+XEThzh7D3mFaKQ== X-Google-Smtp-Source: AGHT+IFrO9ZLbGpyvZoXWDA5xDC5/OgeeKk14bwYttr4Vsl1QkbblpzzE22m+5IMlMDzouCKTVbJ4g== X-Received: by 2002:a05:620a:4002:b0:76e:f3a9:1e12 with SMTP id h2-20020a05620a400200b0076ef3a91e12mr17782229qko.1.1698155583020; Tue, 24 Oct 2023 06:53:03 -0700 (PDT) Received: from ?IPV6:2605:a601:912a:2800::2bb? ([2605:a601:912a:2800::2bb]) by smtp.googlemail.com with ESMTPSA id o8-20020a05620a2a0800b0077263636a95sm3448794qkp.93.2023.10.24.06.53.01 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 24 Oct 2023 06:53:02 -0700 (PDT) Message-ID: <43ee64e4-807f-482a-098d-c6a68d8e6bf4@dunslane.net> Date: Tue, 24 Oct 2023 09:53:00 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: run pgindent on a regular basis / scripted manner Content-Language: en-US To: Jelte Fennema , David Rowley , Peter Eisentraut , akorotkov@postgresql.org, jdavis@postgresql.org, ishii@postgresql.org, efujita@postgresql.org, tomas.vondra@postgresql.org, akapila@postgresql.org, amitlan@postgresql.org, Andres Freund , Michael Paquier Cc: Robert Haas , Peter Geoghegan , Tom Lane , "shiy.fnst@fujitsu.com" , Justin Pryzby , Noah Misch , Bruce Momjian , Magnus Hagander , Alvaro Herrera , Stephen Frost , Jesse Zhang , "pgsql-hackers@postgresql.org" References: <20230811212511.aih23qfthi24zhq4@awork3.anarazel.de> <338202.1691793002@sss.pgh.pa.us> <342032.1691794926@sss.pgh.pa.us> <8c4d8afb-cda1-299c-8011-f60cdaff3999@dunslane.net> <20230812211404.sydbwo2juu7vyhtg@awork3.anarazel.de> <530189.1691880417@sss.pgh.pa.us> <544112.1691886017@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2023-10-18 We 05:07, Jelte Fennema wrote: > I think --enable-indent-checks sounds like a good improvement to the > status quo. But I'm not confident that it will help remove the cases > where only a comment needs to be re-indented. Do commiters really > always run check-world again when only changing a typo in a comment? I > know I probably wouldn't (or at least not always). Yeah. In fact I'm betting that a lot of the offending commits we've seen come into this category. You build, you check, then you do some final polish. That's where a pre-commit hook can save you. cheers andrew -- Andrew Dunstan EDB: https://www.enterprisedb.com