From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Justin Pryzby <pryzby@telsasoft.com>, Robert Haas <robertmhaas@gmail.com>,
        Andrew Dunstan <andrew@dunslane.net>, pgsql-hackers@postgresql.org,
        Thomas Munro <thomas.munro@gmail.com>,
        Melanie Plageman <melanieplageman@gmail.com>,
        Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
        Daniel Gustafsson <daniel@yesql.se>
Subject: Re: Adding CI to our tree
In-reply-to: <20220119011626.nw5cvugqfsy3fyob@alap3.anarazel.de>
References: <63f3be31-d7c4-0ff4-e5f4-7368863da1bc@dunslane.net>
 <20220114233411.2byuid4umwjqbhug@alap3.anarazel.de>
 <20220114235457.GQ14051@telsasoft.com>
 <87a81b91-87bf-c0bc-7e4f-06dffadcf737@dunslane.net>
 <20220117181946.bmvubqpzqxlvmgeh@alap3.anarazel.de>
 <CA+Tgmoap6WXzta=zw97SF73hCfzEWVMtfDFB01svYXMtTzKVVA@mail.gmail.com>
 <20220117192510.txue5mihjaxlngep@alap3.anarazel.de>
 <85428.1642447853@sss.pgh.pa.us>
 <20220117201619.3ltudwhgk2krmoki@alap3.anarazel.de>
 <20220118210847.GC23027@telsasoft.com>
 <20220119011626.nw5cvugqfsy3fyob@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Tue, 18 Jan 2022 17:16:26 -0800"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <440238.1642560607.1@sss.pgh.pa.us>
Date: Tue, 18 Jan 2022 21:50:07 -0500
Message-ID: <440239.1642560607@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/440239.1642560607%40sss.pgh.pa.us>
Precedence: bulk

I just found one thing making check-world slower than it ought to be:
src/test/recovery/t/008_fsm_truncation.pl does

$node_primary->append_conf(
	'postgresql.conf', qq{
fsync = on
wal_log_hints = on
max_prepared_transactions = 5
autovacuum = off
});

There is no reason for this script to be overriding Cluster.pm's
fsync = off setting.  This actually causes parallel check-world to
fail altogether on florican's host, because the initial fsync of
the recovered primary takes more than 3 minutes when there's
conflicting I/O traffic, causing pg_ctl to time out.

This appears to go back to 917dc7d23 of 2016, so I think it just
predates our recognition that we should disable fsync in routine
tests.

			regards, tom lane