Subject: Re: allow_system_table_mods stuff
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <a7455db0-2fc0-4ddc-4d8f-e4c860957a34@2ndquadrant.com>
 <20190913213940.GA20917@alvherre.pgsql> <20191127082619.GB237562@paquier.xyz>
 <f48637b7-ab24-e48b-0b30-519b1170e65c@2ndquadrant.com>
 <2131.1574957504@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
 Alvaro Herrera <alvherre@2ndquadrant.com>,
 pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <440e42c8-948d-d489-cf2f-1f266e087942@2ndquadrant.com>
Date: Fri, 29 Nov 2019 10:30:53 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <2131.1574957504@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-11-28 17:11, Tom Lane wrote:
> I read through the patch set and have just one quibble: in the
> proposed new docs,
> 
> +        Allows modification of the structure of system tables as well as
> +        certain other risky actions on system tables.  This is otherwise not
> +        allowed even for superusers.  This is used by
> +        <command>initdb</command>.  Inconsiderate use of this setting can
> +        cause irretrievable data loss or seriously corrupt the database
> +        system.  Only superusers can change this setting.
> 
> "Inconsiderate" doesn't seem like le mot juste.  Maybe "Ill-advised"?
> 
> (I'm also wondering whether the sentence about initdb is worth keeping.)

committed with those adjustments

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services