Subject: Re: Remove utils/acl.h from catalog/objectaddress.h
To: Alvaro Herrera <alvherre@2ndquadrant.com>
References: <20200309160707.GA3597@alvherre.pgsql>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <44263f2b-da18-1d05-d628-d76a330c79f3@2ndquadrant.com>
Date: Tue, 10 Mar 2020 10:35:51 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200309160707.GA3597@alvherre.pgsql>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2020-03-09 17:07, Alvaro Herrera wrote:
> On 2020-Mar-07, Peter Eisentraut wrote:
> 
>> I noticed that catalog/objectaddress.h includes utils/acl.h for no apparent
>> reason.  It turns out this used to be needed but not anymore. So removed it
>> and cleaned up the fallout.  Patch attached.
> 
> parser/parse_nodes.h already includes nodes/parsenodes.h, so the seeming
> redundancy in places such as
> 
>> diff --git a/src/include/commands/vacuum.h b/src/include/commands/vacuum.h
>> index c27d255d8d..be63e043c6 100644
>> --- a/src/include/commands/vacuum.h
>> +++ b/src/include/commands/vacuum.h
>> @@ -19,6 +19,7 @@
>>   #include "catalog/pg_statistic.h"
>>   #include "catalog/pg_type.h"
>>   #include "nodes/parsenodes.h"
>> +#include "parser/parse_node.h"
> 
> (and others) is not just apparent; it's also redundant in practice.  And
> it's not like parse_node.h is ever going to be able not to depend on
> parsenodes.h, so I would vote to remove nodes/parsenodes.h from the
> headers where you're adding parser/parse_node.h.

OK, committed with your and Tom's changes.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services