Message-ID: <442ba19a-6e8a-3fe3-d404-e9101dfbfcbb@gmail.com>
Date: Mon, 27 Mar 2023 08:54:13 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0)
 Gecko/20100101 Thunderbird/102.9.0
Subject: Re: Generate pg_stat_get_xact*() functions with Macros
Content-Language: en-US
To: Michael Paquier <michael@paquier.xyz>
Cc: "Gregory Stark (as CFM)" <stark.cfm@gmail.com>,
 Andres Freund <andres@anarazel.de>,
 Michael Paquier <michael.paquier@gmail.com>,
 PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <20230112182434.ejffbun4plv2g37k@awork3.anarazel.de>
 <83f7982d-272a-b064-8a0f-8853354edf10@gmail.com>
 <20230113183746.zyncqr2zz3gk6yh6@awork3.anarazel.de>
 <CAM-w4HNq0SmbDa1jCtbmtCzWrx6G7qAGxsjzcOdEyceGOAdJmA@mail.gmail.com>
 <11744b0e-5f7f-aba8-7d9c-2ff0a0c6e2b2@gmail.com>
 <ZBzpDwOMf1ia+M9l@paquier.xyz>
 <631e3084-c5d9-8463-7540-fcff4674caa5@gmail.com>
 <ZB5hipxlAfZoILgZ@paquier.xyz> <ZCDvYgd8OthCttam@paquier.xyz>
 <e2d94c75-a3c1-bc06-f335-73c7225fe5ec@gmail.com>
 <ZCE6X6nsjkaDwz3o@paquier.xyz>
From: "Drouvot, Bertrand" <bertranddrouvot.pg@gmail.com>
In-Reply-To: <ZCE6X6nsjkaDwz3o@paquier.xyz>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: <https://www.postgresql.org/message-id/442ba19a-6e8a-3fe3-d404-e9101dfbfcbb%40gmail.com>
Precedence: bulk

On 3/27/23 8:40 AM, Michael Paquier wrote:
> On Mon, Mar 27, 2023 at 07:45:26AM +0200, Drouvot, Bertrand wrote:
>> Thanks! LGTM, but what about also taking care of pg_stat_get_xact_function_total_time()
>> and pg_stat_get_xact_function_self_time() while at it?
> 
> With a macro that uses INSTR_TIME_GET_MILLISEC() to cope with
> instr_time?  Why not, that's one duplication less.

Yes, something like V1 up-thread was doing. I think it can be added with your current proposal.

Regards,

-- 
Bertrand Drouvot
PostgreSQL Contributors Team
RDS Open Source Databases
Amazon Web Services: https://aws.amazon.com