Message-ID: <4450cd74-1a41-ec03-83ee-fcabc183715d@enterprisedb.com>
Date: Wed, 22 Dec 2021 02:57:02 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101
 Thunderbird/91.2.0
Subject: Re: sequences vs. synchronous replication
Content-Language: en-US
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
References: <712cad46-a9c8-1389-aef8-faf0203c9be9@enterprisedb.com>
 <CAA4eK1KN-Pqe1y5w0uXU2Ttn8DK4WfqgwAbCRbcDt4yzQ88wRA@mail.gmail.com>
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
In-Reply-To: 
 <CAA4eK1KN-Pqe1y5w0uXU2Ttn8DK4WfqgwAbCRbcDt4yzQ88wRA@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/4450cd74-1a41-ec03-83ee-fcabc183715d%40enterprisedb.com>
Precedence: bulk


On 12/19/21 04:03, Amit Kapila wrote:
> On Sat, Dec 18, 2021 at 7:24 AM Tomas Vondra
> <tomas.vondra@enterprisedb.com> wrote:
>>
>> while working on logical decoding of sequences, I ran into an issue with
>> nextval() in a transaction that rolls back, described in [1]. But after
>> thinking about it a bit more (and chatting with Petr Jelinek), I think
>> this issue affects physical sync replication too.
>>
>> Imagine you have a primary <-> sync_replica cluster, and you do this:
>>
>>     CREATE SEQUENCE s;
>>
>>     -- shutdown the sync replica
>>
>>     BEGIN;
>>     SELECT nextval('s') FROM generate_series(1,50);
>>     ROLLBACK;
>>
>>     BEGIN;
>>     SELECT nextval('s');
>>     COMMIT;
>>
>> The natural expectation would be the COMMIT gets stuck, waiting for the
>> sync replica (which is not running), right? But it does not.
>>
> 
> How about if we always WAL log the first sequence change in a transaction?
> 

I've been thinking about doing something like this, but I think it would 
not have any significant advantages compared to using "SEQ_LOG_VALS 0". 
It would still have the same performance hit for plain nextval() calls, 
and there's no measurable impact on simple workloads that already write 
WAL in transactions even with SEQ_LOG_VALS 0.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company