Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fBLG0-0005dk-0B
	for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Apr 2018 14:18:52 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1fBLFy-0007Yj-JI
	for pgsql-hackers@arkaria.postgresql.org; Wed, 25 Apr 2018 14:18:50 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fBLFy-0007YZ-Bq
	for pgsql-hackers@lists.postgresql.org; Wed, 25 Apr 2018 14:18:50 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1fBLFr-0006Ge-Mc
	for pgsql-hackers@postgresql.org; Wed, 25 Apr 2018 14:18:49 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w3PEIbKI004474;
	Wed, 25 Apr 2018 10:18:37 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
cc: Stas Kelvich <s.kelvich@postgrespro.ru>,
        PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: unused_oids script is broken with bsd sed
In-reply-to: <34a54c54-9132-1254-2bc3-d3489fb79728@2ndQuadrant.com>
References: <37D774E4-FE1F-437E-B3D2-593F314B7505@postgrespro.ru>
 <34a54c54-9132-1254-2bc3-d3489fb79728@2ndQuadrant.com>
Comments: In-reply-to Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
	message dated "Wed, 25 Apr 2018 07:54:31 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <4472.1524665917.1@sss.pgh.pa.us>
Date: Wed, 25 Apr 2018 10:18:37 -0400
Message-ID: <4473.1524665917@sss.pgh.pa.us>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Precedence: bulk

Andrew Dunstan <andrew.dunstan@2ndquadrant.com> writes:
> +many for rewriting in perl. Do you want to have a go at that? If not I
> will.

+1 ... I was mildly astonished that this didn't already have to happen
as part of the bootstrap data conversion effort.  It's certainly not
hard to imagine future extensions to the .dat file format that would
break this script, and duplicate_oids too.  I think we should rewrite
both of them to use the Catalog.pm infrastructure.

			regards, tom lane