Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rT6QE-000ROa-PT for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jan 2024 20:34:03 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rT6QB-003X30-Qg for pgsql-hackers@arkaria.postgresql.org; Thu, 25 Jan 2024 20:33:59 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rT6QB-003X2s-He for pgsql-hackers@lists.postgresql.org; Thu, 25 Jan 2024 20:33:59 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by makus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rT6Q9-003MGi-3r for pgsql-hackers@lists.postgresql.org; Thu, 25 Jan 2024 20:33:58 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 40PKXpV4448056; Thu, 25 Jan 2024 15:33:51 -0500 From: Tom Lane To: Andrew Dunstan cc: Jeevan Chalke , Peter Eisentraut , PostgreSQL Hackers Subject: Re: More new SQL/JSON item methods In-reply-to: References: <1d092c02-8249-4e56-8b8e-ae4db95b8fde@eisentraut.org> <5d37428e-0753-e721-8e77-81cc4d0dc9f1@dunslane.net> <439811.1706211069@sss.pgh.pa.us> Comments: In-reply-to Andrew Dunstan message dated "Thu, 25 Jan 2024 15:25:28 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <448054.1706214831.1@sss.pgh.pa.us> Date: Thu, 25 Jan 2024 15:33:51 -0500 Message-ID: <448055.1706214831@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > On 2024-01-25 Th 14:31, Tom Lane wrote: >> (The reported crashes seem to be happening later during a >> recursive invocation, seemingly because JsonbType(jb) is >> returning garbage. So there may be another bug after this one.) > I don't think so. AIUI The first call deals with the '$' and the second > one deals with the '.string()', which is why we see the error on the > second call. There's something else going on, because I'm still getting the assertion failure on my Mac with this fix in place. Annoyingly, it goes away if I compile with -O0, so it's kind of hard to identify what's going wrong. regards, tom lane