Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81.1.4\))
Subject: Re: Fix gistkillitems & add regression test to microvacuum
From: Andrey Borodin <x4mmm@yandex-team.ru>
In-Reply-To: <CALdSSPgfFWUBc8RoOZe5PmoUGa4LJUDeMTcAT8HwXGCMGJ9uBA@mail.gmail.com>
Date: Tue, 20 Jan 2026 15:30:30 +0500
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <449DFC8A-CF54-493E-9366-AF9C73C782AA@yandex-team.ru>
References: <CALdSSPgZWX_D8+Fx4YQqRN5eW5iSx_rJdqQhCfdWTvqKXVfJ4w@mail.gmail.com>
 <CALdSSPgPs=gKWkKN0=4yBd49FBY=ijxBz4YGV64vfVMK7YQhpw@mail.gmail.com>
 <CALdSSPiaQptrccvRoHhP3=YqN9-K8duXfLHHm3G=+7FVL8A-Xw@mail.gmail.com>
 <CALdSSPh-QtT8NrhtKsNWwFVF3D4KX6Wy3qs-FPc16c6VAECEyg@mail.gmail.com>
 <CALdSSPgfFWUBc8RoOZe5PmoUGa4LJUDeMTcAT8HwXGCMGJ9uBA@mail.gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Archived-At: <https://www.postgresql.org/message-id/449DFC8A-CF54-493E-9366-AF9C73C782AA%40yandex-team.ru>
Precedence: bulk


> On 15 Jan 2026, at 22:59, Kirill Reshke <reshkekirill@gmail.com> =
wrote:
>=20
> PFA v2 which leaves the test in-place.
>=20
> Also commit message improvements.

Yeah, killtuples for GiST root page is broken. Your patch is fixing it.
I don't think we should backpatch this, the bug is harmless, but for =
master the patch LGTM.
It would be good to assign so->curBlkno and so->curBlkno together. But =
gistScanPage() is the only place with access to the block number.

+# Test gist, but with fewer rows - that killitems used to be buggy.

Probably, in this comment we can explicitly say that killitems was =
buggy, but now is fixed.

Thanks!


Best regards, Andrey Borodin.=