Feedback-ID: i7c334307:Fastmail
Content-Type: multipart/signed;
	boundary="Apple-Mail=_FEA8B938-5322-432E-B640-D007472BECCA";
	protocol="application/pgp-signature";
	micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.600.51.1.1\))
Subject: Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim,
 replace, split_part
From: "David E. Wheeler" <david@justatheory.com>
In-Reply-To: 
 <CA+v5N40+gPfir3ShsA53SLWeQa5eMy7Bm3vnOKLa5YLNEwZO7w@mail.gmail.com>
Date: Sat, 12 Jul 2025 14:24:25 -0400
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
 Peter Eisentraut <peter@eisentraut.org>,
 Robert Haas <robertmhaas@gmail.com>,
 Alexander Korotkov <aekorotkov@gmail.com>,
 pgsql-hackers <pgsql-hackers@lists.postgresql.org>,
 Andrew Dunstan <andrew@dunslane.net>
Message-Id: <44F87861-8026-4AB8-95B0-E755E22C6B3F@justatheory.com>
References: 
 <CA+v5N40sJF39m0v7h=QN86zGp0CUf9F1WKasnZy9nNVj_VhCZQ@mail.gmail.com>
 <145894.1727298237@sss.pgh.pa.us>
 <CAPpHfdtGhn_5jfLoepOScyqT+FXYB9QtV-OEprychDcMJco7mw@mail.gmail.com>
 <CA+v5N42PVJH3HbwLE1yC75XR6E5zGnCCdtSUXfgFwtGyPP8XYg@mail.gmail.com>
 <CA+Tgmob03B6h1SMsi7vs9uOX+vrqg_tyhh--mKC3BaTJ08qKYA@mail.gmail.com>
 <7e9debe6-4e96-4b0d-a801-b531e962ef43@eisentraut.org>
 <01DC1C38-0692-461B-AA63-5394330356BE@gmail.com>
 <2568904.1748022721@sss.pgh.pa.us>
 <D57D3B5E-AF55-4F7F-9E55-FE06EE8ED811@justatheory.com>
 <40912112-7FFE-400F-A38F-368827C4BDF1@gmail.com>
 <D201EEF7-8681-458E-B287-7B8F058DC712@justatheory.com>
 <176C517D-2DEB-4CAB-9AE4-261079D313B9@justatheory.com>
 <8FD5F4CF-9059-40C1-9F0A-C3CBA8DFE17A@justatheory.com>
 <C54B0664-34F5-46E2-9094-5798E68A2A3F@justatheory.com>
 <696ECBBC-3CBF-4522-AE66-E48225688E93@gmail.com>
 <59C63857-406D-4704-A1EB-9BF3AA639C86@justatheory.com>
 <06FA8975-2E21-46A5-B510-028B3B967EB2@justatheory.com>
 <2F58E05D-D319-4CD3-8805-E1A8A2482A1A@justatheory.com>
 <4A96ACDB-78A1-4434-8C25-7C9716A7D421@justatheory.com>
 <A7D78196-E287-4716-8507-BE09C6DE3C82@justatheory.com>
 <4904EA5B-C6CA-42BD-BF08-C89325240C9D@gmail.com>
 <84727E10-62B7-4FE4-B487-E7044C7C0A1F@justatheory.com>
 <6CD16A54-BFEE-4CB5-84AC-F3B46289FA6D@justatheory.com>
 <D3137F93-B6CA-45D0-BF9A-43ED5DF7859B@justatheory.com>
 <7D19A273-1306-4F4C-9DFD-CE16F44790CB@justatheory.com>
 <CA+v5N40+gPfir3ShsA53SLWeQa5eMy7Bm3vnOKLa5YLNEwZO7w@mail.gmail.com>
To: Florents Tselai <florents.tselai@gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/44F87861-8026-4AB8-95B0-E755E22C6B3F%40justatheory.com>
Precedence: bulk


--Apple-Mail=_FEA8B938-5322-432E-B640-D007472BECCA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Jul 12, 2025, at 00:07, Florents Tselai <florents.tselai@gmail.com> =
wrote:

> To recap so far;=20
>=20
> - I like your changes and renames on the parser/lexer; it indeed looks =
much cleaner now and will help with future improvements.

Thanks!

> - I also like the addition of executeStringInternalMethod ; it'll help =
us add more stuff in the future (reminder that for the original patch I =
implemented the methods I'd like more, but string operations are quite =
more).

Agreed.

> - AFAICT no test cases / results have changed with your versions; is =
this correct ?

I made some minor changes, notably to test alternate trim values and a =
negative position passed to split_part():

```patch
--- a/src/test/regress/sql/jsonb_jsonpath.sql
+++ b/src/test/regress/sql/jsonb_jsonpath.sql
@@ -627,7 +627,7 @@ rollback;
 select jsonb_path_query('"   hello   "', '$.ltrim(" ")');
 select jsonb_path_query('"   hello   "', '$.ltrim(" ")');
 select jsonb_path_query('"   hello   "', '$.ltrim()');
-select jsonb_path_query('"   hello   "', '$.ltrim()');
+select jsonb_path_query('"zzzytest"', '$.ltrim("xyz")');
 select jsonb_path_query('null', '$.ltrim()');
 select jsonb_path_query('null', '$.ltrim()', silent =3D> true);
 select jsonb_path_query('[]', '$.ltrim()');
@@ -647,13 +647,13 @@ select jsonb_path_query_array('["  maybe  ", "  =
yes", "  no"]', '$[*].ltrim().ty
   -- test .rtrim()
 select jsonb_path_query('"   hello   "', '$.rtrim(" ")');
-select jsonb_path_query('"   hello   "', '$.rtrim(" ")');
+select jsonb_path_query('"testxxzx"', '$.rtrim("xyz")');
 select jsonb_path_query('"   hello   "', '$.rtrim()');
 select jsonb_path_query('"   hello   "', '$.rtrim()');
   -- test .btrim()
 select jsonb_path_query('"   hello   "', '$.btrim(" ")');
-select jsonb_path_query('"   hello   "', '$.btrim(" ")');
+select jsonb_path_query('"xyxtrimyyx"', '$.btrim("xyz")');
 select jsonb_path_query('"   hello   "', '$.btrim()');
 select jsonb_path_query('"   hello   "', '$.btrim()');
  @@ -723,6 +723,7 @@ select jsonb_path_query('"hello world"', =
'$.replace("hello","bye") starts with "
   -- Test .split_part()
 select jsonb_path_query('"abc~@~def~@~ghi"', '$.split_part("~@~", 2)');
+select jsonb_path_query('"abc,def,ghi,jkl"', '$.split_part(",", -2)');
   -- Test string methods play nicely together
 select jsonb_path_query('"hello world"', =
'$.replace("hello","bye").upper()');
```

Best,

David


--Apple-Mail=_FEA8B938-5322-432E-B640-D007472BECCA
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEd+KfmbOQis6ZycGGkt9idPjIgfEFAmhyqFkACgkQkt9idPjI
gfFZUBAAkpa7z9AjZIeNp5+QM9jriCN/O4GXKCLCwyRmbIrLPYvr0VJ4c77+WNf/
eDDRuWJ47p6EbDiptim24KsEkbLKBDiufYa9EylcuTv2p9ce4XO0oDIQW4FUm6Fs
jktSRqmdlNucd0Z/LxzsKSKUfR6LiOvLADr5QnsU9TXHptPfiMBM3H2dqhmvcLO0
LAu1d8So9i6rW5F6Xrv8EQ2kv0gIw84fohR36kkUEPaFWPK+eMSRRnXIAi2GHYqR
/NGIMI8k6QxOMuaXKb5KFTei6KsH54le5CFEwm0gdjzfxDovEpzzn+vx/gDgEMdJ
oWhGK+acJK6IVQWFwDrYMoCr1hOQB3L/XjcMFCiuJFHpWxmtzo5qKPzx7iF3EhkN
wW/yCQacGNqesBdldG5itIC06ezzrNrb8uLTazjVaVSIRorl/9Nr6aN5OulMfZk9
0NzP98qEf7lbkOKB3m2W+ViSFzdyRrA4PSUA8AEE7+xGykKyPvDvh9TPo7rR9XKv
FrvXpNzuuHAVcGXb2G3JRTbFvsr5ldqV0T004lYXnTh9UYrwTPajBmg+wqu280j4
+sXmrezsW5lIAGQjy/Kbj7AcQir6Cjn9iFhglbVbX4sL8sSxQgUOvYRsWs1U8yuw
XYn2WiKFUgtZz0afyhotOeXXLhyahCaHlMBRqQSeExUrIbVIUwI=
=ylo4
-----END PGP SIGNATURE-----

--Apple-Mail=_FEA8B938-5322-432E-B640-D007472BECCA--