X-Original-To: pgsql-hackers-postgresql.org@postgresql.org Received: from localhost (wm.hub.org [200.46.204.128]) by postgresql.org (Postfix) with ESMTP id 0DCD99FB1C8 for ; Mon, 4 Sep 2006 21:05:55 -0300 (ADT) Received: from postgresql.org ([200.46.204.71]) by localhost (mx1.hub.org [200.46.204.128]) (amavisd-new, port 10024) with ESMTP id 54596-05 for ; Tue, 5 Sep 2006 00:05:44 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey- Received: from lists.commandprompt.com (host-130.commandprompt.net [207.173.203.130]) by postgresql.org (Postfix) with ESMTP id 4F6429FB30E for ; Mon, 4 Sep 2006 21:05:38 -0300 (ADT) Received: from [192.168.1.50] (or-67-76-146-141.sta.embarqhsd.net [67.76.146.141]) (authenticated bits=0) by lists.commandprompt.com (8.13.7/8.13.6) with ESMTP id k8505PO5021517 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 4 Sep 2006 17:05:26 -0700 Message-ID: <44FCBF55.9050409@commandprompt.com> Date: Mon, 04 Sep 2006 17:05:41 -0700 From: "Joshua D. Drake" Organization: Command Prompt, Inc. User-Agent: Thunderbird 1.5.0.5 (X11/20060728) MIME-Version: 1.0 To: Gavin Sherry CC: Tom Lane , Bruce Momjian , Alvaro Herrera , Gregory Stark , pgsql-hackers@postgresql.org Subject: Re: [PATCHES] Trivial patch to double vacuum speed References: <200609042253.k84MrJp19066@momjian.us> <15844.1157413254@sss.pgh.pa.us> <44FCBC03.2000507@commandprompt.com> In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV version 0.88.3, clamav-milter version 0.88.3 on projects.commandprompt.com X-Virus-Status: Clean X-Greylist: Sender succeded SMTP AUTH authentication, not delayed by milter-greylist-1.6 (lists.commandprompt.com [192.168.2.159]); Mon, 04 Sep 2006 17:05:27 -0700 (PDT) X-Virus-Scanned: Maia Mailguard 1.0.1 X-Spam-Status: No, hits=0.135 tagged_above=0 required=5 tests=FORGED_RCVD_HELO X-Spam-Level: X-Archive-Number: 200609/410 X-Sequence-Number: 89939 Gavin Sherry wrote: > On Mon, 4 Sep 2006, Joshua D. Drake wrote: > >>> I don't have a concrete proposal to make, but I do think that the >>> current patch-queue process is not suited to the project as it stands >>> today. Maybe if this issue-tracking stuff gets off the ground, we >>> could let developers place ACK or NAK flags on patches they've looked >>> at, and have some rule about ACK-vs-NAK requirements for something to go >>> in. >> How about *requiring* test cases that prove the patch? > > People including regression tests is not a replacement for code review. Uhmmm, of course not? :). A test case does however help show that the person thought through what they were doing :) Even if they were cranked in the process. Sincerely, Joshua D. Drake > For a non-trivial patch, an SQL test will only exercise a few code paths . > Moreover, it wont say anything about code quality, maintainability or > general correctness or completeness. It will still have to be reviewed. > > Thanks > > Gavin > > ---------------------------(end of broadcast)--------------------------- > TIP 2: Don't 'kill -9' the postmaster > -- === The PostgreSQL Company: Command Prompt, Inc. === Sales/Support: +1.503.667.4564 || 24x7/Emergency: +1.800.492.2240 Providing the most comprehensive PostgreSQL solutions since 1997 http://www.commandprompt.com/