Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1d9ACy-0004N0-59 for pgsql-hackers@arkaria.postgresql.org; Fri, 12 May 2017 13:02:12 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1d9ACw-0004yI-DR for pgsql-hackers@arkaria.postgresql.org; Fri, 12 May 2017 13:02:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d9ACv-0004t6-4E for pgsql-hackers@postgresql.org; Fri, 12 May 2017 13:02:09 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1d9ACr-0007Qg-CW for pgsql-hackers@postgresql.org; Fri, 12 May 2017 13:02:08 +0000 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id D1F9A20696; Fri, 12 May 2017 09:02:03 -0400 (EDT) Received: from frontend2 ([10.202.2.161]) by compute7.internal (MEProxy); Fri, 12 May 2017 09:02:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s= fm1; bh=P9x11aJ02GCwjGghQSeTPNpYLTUZMG92RAcS9uqPVaY=; b=iFmkXRI9 bMwd+Pas3DGEQdZeRV7PP3TLiinfabPS2sZwQZP3t8k1D7hYH5tOgyuY5/SfJjpN HIN7XGIFvJQJaA3dGYYNOen4daJcVWbZ9uO/0BT0qPTVkmqFXORUx/bFFpLfuQqc muIAODcYQTDRu58q8536UNaqYodjJue6VK/57ta9n8hWdMKA/6ee2aHqUw89QmVR HisfuQt46KO7pwldZYbiMpEZvplSsPjoN8vi/oviuYznu3cxrnka/RtqOtrw5QM1 yGGpgwinnscacyY6PZsRXnOTuUmQqz8r9m5Yeb8/LhknNkFVRvhSeDwDcXlIs8Tl R1csoGg+lHeCSg== X-ME-Sender: X-Sasl-enc: d3oF+LBsg/4T0479uTscs1l/HAMHWpQH+hi6JU2/3QNA 1494594123 Received: from april.local (c-73-13-66-39.hsd1.pa.comcast.net [73.13.66.39]) by mail.messagingengine.com (Postfix) with ESMTPA id 7F8BB24950; Fri, 12 May 2017 09:02:03 -0400 (EDT) Subject: Re: logical replication syntax (was DROP SUBSCRIPTION, query cancellations and slot handling) To: Petr Jelinek , Tom Lane References: <27478.1493727233@sss.pgh.pa.us> <29431.1493730652@sss.pgh.pa.us> <360a1932-7af4-609b-94f1-2ad419430869@2ndquadrant.com> <9174dc31-787a-a2f6-818f-cb4a5c1dfddb@2ndquadrant.com> <30166.1493731904@sss.pgh.pa.us> <2b931e0e-d9f2-c79e-b74b-91df2f915e66@2ndquadrant.com> <96e95255-94d9-0881-16ba-bdb6d05bb307@2ndquadrant.com> <52a1f160-db1f-49c6-9832-498dbea58ae8@2ndquadrant.com> <35f3592b-8582-e348-1823-f8edfcf03ba3@2ndquadrant.com> <5f6ad263-af87-2aee-b86b-8bf7e3260b73@2ndquadrant.com> <20856826-de0f-f630-4c67-36dca21037ad@2ndquadrant.com> Cc: Robert Haas , Michael Paquier , PostgreSQL mailing lists From: Peter Eisentraut Organization: 2ndQuadrant Message-ID: <44bebe74-43aa-661f-b6ec-5c824881a720@2ndquadrant.com> Date: Fri, 12 May 2017 09:02:15 -0400 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20856826-de0f-f630-4c67-36dca21037ad@2ndquadrant.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-hackers Precedence: bulk Sender: pgsql-hackers-owner@postgresql.org On 5/9/17 11:43, Petr Jelinek wrote: > Here is rebased version of the other patch (the interface rework). I > also fixed the tab completion there. Committed. One small thing I changed, to make it look more like CREATE/ALTER TABLE, is that the CREATE commands use WITH (...) but the ALTER commands use SET (...). -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers